fix(pptx): import-fidelity fixes for think-cell / brand-template decks#75
Merged
Merged
Conversation
Broad set of importer fixes surfaced reviewing the Intero master template: hidden-shape skipping, run highlight, cap/letter-case, weight-named font families, per-cell table fills/borders/spans/widths/heights/anchors + rich cell runs, Wingdings bullet glyph mapping, empty-paragraph bullet/blank-line handling + trailing-empty trim, block-arrow paths, lnRef outline colour, text-bearing shape fill/border/radius, spAutoFit no-wrap, and per-line hanging-indent bullets. See .changeset/intero-import-fidelity.md for the full list. Adds 14 importer regression tests (round2/roundtrip).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A batch of PPTX importer fidelity fixes found by reviewing a real brand/think-cell master template (Intero) slide-by-slide against PowerPoint. Each item was verified against the source deck and covered by a regression test.
Text
<a:rPr><a:highlight>) — the yellow think-cell callouts.cap="all"/"small"as a render-time letter-case transform, including when inherited from a placeholder's list style.Gilroy ExtraBold→800,… Medium→500, …) so substitute fonts render at the right heaviness.<a:lstStyle>defRPrnow feeds run defaults (font/size/weight) for non-placeholder text boxes.Bullets / lists
ü→✓,q→☐,§→▪, …).Tables
gridSpan/hMerge/rowSpan/vMerge), per-cell vertical anchor, and rich per-cell runs (highlight / bold / ✓ glyphs / bullet breaks). Unfilled cells stay transparent instead of inheriting a sibling's fill.Shapes
hidden="1"(think-cell "do not delete" data objects).down/up/left/rightArrow).<p:style><a:lnRef>so dashed/outlined shapes draw.<a:bodyPr><a:spAutoFit>no-wrap for short single-line labels; skip the arrow-tip text inset on no-fill label shapes.Testing
pnpm --filter @textcortex/slidewise test→ 91 passed / 9 skipped (14 new importer regression tests inround2/roundtrip).pnpm typecheckclean.Notes
.changeset/intero-import-fidelity.md).