QVAC-25501 fix: support header-only safetensors fitting - #46
Merged
Merged
Conversation
iancris
reviewed
Sep 24, 2026
iancris
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What problem does this PR solve?
sd_fit_paramsrejects header-only safetensors because the shared reader requires tensor payloads to exist. This prevents metadata-only fitting of models with safetensors components.📝 How does it solve it?
🧪 How was it tested?
8268f58.8b9c313: all three supplied malformed headers and F64/I64 overflow cases were accepted.8268f58rejects all five; the real FLUX header produces identical metadata for all 1,438 parsed tensors. New regression cases fail against the old reader and pass after the fix. Coverage also includes zero-dimension intermediate overflow, invalid shape types, valid scalar/zero-sized/five-dimensional shapes, strict loading, andSD_FIT_ERRORcleanup.1266832/ engine8268f58: 23/23 runner groups on each device, no crashes, 48 non-skipped cases and 31 existing skips per device. Direct header-only fitting is covered by native engine tests. Existing mobile settings skip ABot and several large-model generation cases.git diff --checkpassed.The review fix and revalidation are complete; this PR is ready for re-review. Merge order: merge this PR after review, publish the merged engine pin in the native dependency registry, then replace the addon overlay with that registry version and validate the final addon revision.