feat: add test alias support for playwright#271
Open
olexandr13 wants to merge 2 commits into
Open
Conversation
|
🌀 Tests overview by Testomatio Found 268 mocha tests in 26 files ✔️ Added 12 tests+ analyzer: should also scan TypeScript files when given a JS-only glob and TypeScript is enabled
+ analyzer: buildPatterns expands a trailing .js extension to TS variants only when TypeScript is enabled
+ playwright parser: test with --line-numbers option: should parse annotations (.skip/.fixme/.fail) on a custom test alias
+ playwright parser: test with --line-numbers option: should not parse custom alias annotations when the alias is not configured
+ playwright parser: annotations status (.skip/.fixme/.fail/.slow/.todo): registers every named test exactly once (runtime no-title forms excluded)
+ playwright parser: annotations status (.skip/.fixme/.fail/.slow/.todo): marks .todo as skipped
+ playwright parser: annotations status (.skip/.fixme/.fail/.slow/.todo): keeps .fail tests runnable (not skipped)
+ playwright parser: annotations status (.skip/.fixme/.fail/.slow/.todo): keeps .slow tests runnable (not skipped)
+ playwright parser: annotations status (.skip/.fixme/.fail/.slow/.todo): treats .fail inside a skipped suite as skipped
+ playwright parser: annotations status (.skip/.fixme/.fail/.slow/.todo): ignores runtime `test.fail()` / `test.skip()` / `test.slow()` calls without a title
+ playwright parser: annotations status (.skip/.fixme/.fail/.slow/.todo): should not leak a skipped suite onto sibling tests declared after it
+ playwright parser: annotations status (.skip/.fixme/.fail/.slow/.todo): should not crash when test is assigned to a variable or inside an array (regression for issue #1)🗑️ Removed 1 test- playwright parser: test with --line-numbers option: should not crash when test is assigned to a variable or inside an array (regression for issue #1)📑 List all tests
📝 tests/updateIds_codeceptjs_test.js
📝 tests/updateIds_gauge_test.js
📝 tests/updateIds_markdown_test.js
📝 tests/updateIds_nightwatch_test.js
📝 tests/updateIds_playwright_test.js
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: tests with custom
testfixture name (alias) liketestFixtureand annotation like.skipwas not parsed by check-tests.E.g.
testFixture.skip()was just ignored.Extends Playwright parsing so custom test aliases/fixtures (configured via --test-alias) are also recognized on the annotation forms
.skip,.fixme,.fail, and.slow— not just plain test declarations.Previously only
test/it/describewere recognized for annotations. Projects using extended Playwright test objects (e.g.const testFixture = base.extend(...)) had theirtestFixture.skip(...)/.fixme(...)testsmissed or mishandled.