fix(evidence): an untitled page is named by its trimmed address in the log - #406
Merged
Merged
Conversation
…e log Chrome titles a page without <title> by its address, query and fragment included, and the recorder stored that title (or the raw address when there was none) as the recorded tab's name. A reset link such as /reset?token=… therefore reached the uploaded .txt in full on its "Recorded tab:" line, right above the trimmed "URL:" line. The name is now the page's own document.title, read once the page has taken the recorder's scripts. When the page has no title, or will not say, the name is the address cut to scheme, host, port and path — no sign-in, query or fragment. Chrome's tab title is no longer read. The Rec button and its toast show the same name. Mutations through EV_SRC: 9 of 9 caught. In real Chromium an untitled /plain?token=SECRET123#frag is logged as http://127.0.0.1:<port>/plain, and a titled page is still logged as "Checkout". Closes #404 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #404