fix(screen-recording): Sign out, Disconnect and Forget stop the screen recording too - #405
Merged
Merged
Conversation
…n recording too The erase stopped only the console & network recorder. Clearing session storage dropped the screen recording's state but not the recorder: it kept taking frames, the debugger stayed on the tab (a new recording there failed with "Another debugger is already attached"), and at the cap the take came back and its review opened by itself. A take waiting for review survived as well. The erase now asks the worker to wipe the screen recording beside the log, both at once under the same 5 s timeout. The worker takes the cast off the tab, closes the recorder page (the capture and every take's bytes end with it), removes the recording's keys and announces it; the review closes itself and other panels drop their plaque. A take pushed after its recorder page is gone is not parked. If either recorder will not stop, the erase still happens and the warning names which one. The confirm texts and the settings guide list the screen recording. Mutations through SREC_SRC, SCREENS_SRC and SHARED_MODULES: 19 of 19 caught. In real Chromium, after Sign out mid-recording there is no recorder page and no debugger session left, a new recording starts on the tab, a waiting take's blob no longer fetches, and with a 10 s cap nothing comes back 15 s later. Closes #403 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #403