fix(handoff): a store install never asks for handoff.json - #401
Merged
Merged
Conversation
Every open of the panel, the test editor and the attachment viewer fetched handoff.json, the file a host app such as Testeiya drops next to the manifest of an unpacked copy. A store install never has it, and Chrome logs the failed load as a red net::ERR_FILE_NOT_FOUND even though the code catches it — the first thing a store reviewer or a tester sees in the console. The store writes update_url into the manifest of everything it installs (checked on five store extensions); ours has none, and neither zip adds one. readFile() now returns before the fetch when getManifest() carries it, so ready() and decline() skip the file in all three pages. An unpacked copy, Testeiya's --load-extension one included, reads it exactly as before, and a manifest that cannot be read counts as unpacked. Probed through SHARED_MODULES: dropping the check, the try/catch, reading `key` instead, or treating a throw as the store each turn H41 or H42 red. In real Chromium, a copy with update_url added asks for the file 0 times on all three pages on this branch, and once per page on main; without it, both ask. Closes #394 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #394