fix(step-recorder): what a field holds is its value, and no name or packet fact reads it - #399
Merged
Merged
Conversation
…acket fact reads it With "Never record entered values" on, the step said "Type text into the Notes field", but the text typed into a composer or a textarea still went out: into the packet the AI polish sends (element.text, icon, near.heading, near.siblings, after.counter, after.dialog), and on some pages into the step itself — the row of an editable cell, the section under an editable heading, a label that wraps its composer, a composer with a combobox role, an aria-labelledby that lists the field, a cell that holds one. The text inside a contenteditable or a textarea is now read in one place only, the step's value, where masking applies. inField() and plainText() in rec-naming.js give every reader of page text the same rule: the naming walks, cleanText and cleanLabelText, the packet's element facts, the badge and the notes. A read-only (contenteditable="false") cell still names its row. Cost, accepted: an editable heading or cell no longer names a section or a row, with the setting off too. Probed, each against a scratchpad copy: all 16 behavioural reverts turn an H row red; only plainText's fast path survives, and it changes no output. The same 19 cases in real Chromium leak on main and are clean here. Closes #390 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #390