Fix Kafka container starting before the broker is ready

packages/modules/kafka/src/kafka-container-latest.test.ts

@@ -18,6 +18,14 @@ describe("KafkaContainer", { timeout: 240_000 }, () => {
     // }
   });
 
+  it("should be listening when started", async () => {
+    await using container = await new KafkaContainer(IMAGE).start();
+
+    const { exitCode } = await container.exec(["bash", "-c", "</dev/tcp/localhost/9093"]);
+
+    expect(exitCode).toBe(0);
+  });
+
   it("should connect with custom network", async () => {
     await using network = await new Network().start();
     await using container = await new KafkaContainer(IMAGE).withNetwork(network).start();

packages/modules/kafka/src/kafka-container.ts

@@ -193,7 +193,8 @@ export class KafkaContainer extends GenericContainer {
     const boundPorts = BoundPorts.fromInspectResult(client.info.containerRuntime.hostIps, inspectResult).filter(
       this.exposedPorts
     );
-    const waitStrategy = await this.selectWaitStrategy(client, dockerInspectResult, this.originalWaitStrategy);
+    this.waitStrategy = this.originalWaitStrategy;
+    const waitStrategy = await this.selectWaitStrategy(client, dockerInspectResult);
     if (this.startupTimeoutMs !== undefined) {
       waitStrategy.withStartupTimeout(this.startupTimeoutMs);
     }

packages/modules/redpanda/src/redpanda-container.ts

@@ -79,7 +79,8 @@ export class RedpandaContainer extends GenericContainer {
     const boundPorts = BoundPorts.fromInspectResult(client.info.containerRuntime.hostIps, inspectResult).filter(
       this.exposedPorts
     );
-    const waitStrategy = await this.selectWaitStrategy(client, dockerInspectResult, this.originalWaitStrategy);
+    this.waitStrategy = this.originalWaitStrategy;
+    const waitStrategy = await this.selectWaitStrategy(client, dockerInspectResult);
     if (this.startupTimeoutMs !== undefined) {
       waitStrategy.withStartupTimeout(this.startupTimeoutMs);
     }

packages/testcontainers/src/generic-container/generic-container.ts

@@ -134,13 +134,12 @@ export class GenericContainer implements TestContainer {
 
   protected async selectWaitStrategy(
     client: ContainerRuntimeClient,
-    inspectResult: ContainerInspectInfo,
-    waitStrategy: WaitStrategy | undefined = this.waitStrategy
+    inspectResult: ContainerInspectInfo
   ): Promise<WaitStrategy> {
     return selectWaitStrategy({
       client,
       inspectResult,
-      waitStrategy,
+      waitStrategy: this.waitStrategy,
       healthCheck: this.healthCheck,
       imageNames: [this.imageName.string],
     });