Repository navigation
Test Valkey and Redis against every supported major version - #1589
Merged
Merged
Conversation
This was referenced Oct 12, 2026
cristianrgreco
marked this pull request as ready for review
October 13, 2026 15:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First batch of bringing existing modules in line with the supported-versions rule proposed in #1587: a module's tests cover the latest release of every major version the vendor still supports.
Each test file has one
IMAGESlist, oldest major first and theDockerfileimage last, and the whole suite runs against every entry withdescribe.each(IMAGES). The images run one after another and each image's tests run concurrently, as the single-image suite did:{ concurrent: false }ondescribe.each,it.concurrenton the tests. Older majors are pinned to the exact tag of their latest release.IMAGESDockerfile(9.1)Dockerfile(8.10)In the Redis suite the three Redis Stack tests moved out of the looped block; they use a different image and would otherwise run three times.
NATS (2.x), etcd (3.x) and CouchDB (3.x) have a single supported major, so their tests stay on the
Dockerfileimage and are not changed.Verification
Local, macOS arm64, Docker Desktop, both suites in full against every listed image:
npm run format,npm run lint,npm run knip: clean.inside_blockmarker used by the two docs pages still resolves to one block.read ECONNRESETaftercontainer.restart()on Valkey 9.1, Valkey 7.2.14 and Redis 6.2.24. It fails on the newest image too, so it is not version specific; Fix stale mapped ports after restarting a container on Docker Desktop #1599 addresses it.Left to CI: Podman, Node 22 and 24, linux/amd64, and the docs build.
Baseline job times on
main(run 38287125470, docker 22 / docker 24 / podman 22 / podman 24, seconds): valkey 26/37/27/34, redis 34/31/39/40.Not breaking
Test files only. No module source, exports or
Dockerfilechanged.