Skip to content

Test Valkey and Redis against every supported major version - #1589

Merged
cristianrgreco merged 5 commits into
mainfrom
claude/supported-versions-key-value
Oct 13, 2026
Merged

cristianrgreco merged 5 commits into
mainfrom
claude/supported-versions-key-value

Conversation

@cristianrgreco

@cristianrgreco cristianrgreco commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

First batch of bringing existing modules in line with the supported-versions rule proposed in #1587: a module's tests cover the latest release of every major version the vendor still supports.

Each test file has one IMAGES list, oldest major first and the Dockerfile image last, and the whole suite runs against every entry with describe.each(IMAGES). The images run one after another and each image's tests run concurrently, as the single-image suite did: { concurrent: false } on describe.each, it.concurrent on the tests. Older majors are pinned to the exact tag of their latest release.

Module IMAGES Source
valkey 7.2.14 (EOL 2029-04-16), 8.1.10 (EOL 2030-03-31), Dockerfile (9.1) endoflife.date
redis 6.2.24 (EOL 2027-04-01), 7.4.11 (EOL 2029-12-01), Dockerfile (8.10) endoflife.date

In the Redis suite the three Redis Stack tests moved out of the looped block; they use a different image and would otherwise run three times.

NATS (2.x), etcd (3.x) and CouchDB (3.x) have a single supported major, so their tests stay on the Dockerfile image and are not changed.

Verification

Local, macOS arm64, Docker Desktop, both suites in full against every listed image:

Module Tests Result
valkey 7 → 21 21 passed
redis 12 → 30 30 passed
  • npm run format, npm run lint, npm run knip: clean.
  • Every inside_block marker used by the two docs pages still resolves to one block.
  • In one earlier run made while another test suite was loading the same Docker VM, "should reconnect with volume and persistence data" failed with read ECONNRESET after container.restart() on Valkey 9.1, Valkey 7.2.14 and Redis 6.2.24. It fails on the newest image too, so it is not version specific; Fix stale mapped ports after restarting a container on Docker Desktop #1599 addresses it.

Left to CI: Podman, Node 22 and 24, linux/amd64, and the docs build.

Baseline job times on main (run 38287125470, docker 22 / docker 24 / podman 22 / podman 24, seconds): valkey 26/37/27/34, redis 34/31/39/40.

Not breaking

Test files only. No module source, exports or Dockerfile changed.

@cristianrgreco cristianrgreco changed the title Test Valkey, Redis, NATS, etcd and CouchDB against their oldest supported versions Test Valkey and Redis against every supported major version Oct 13, 2026
@cristianrgreco
cristianrgreco merged commit 496a57d into main Oct 13, 2026
22 checks passed
@cristianrgreco
cristianrgreco deleted the claude/supported-versions-key-value branch October 13, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Improvements that do not change functionality patch Backward compatible bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant