Repository navigation
Allow knip updates and remove the redundant Firestore dev dependency - #1509
Merged
Merged
Conversation
Use a caret range like the other dev dependencies. The lockfile still installs 6.39.0.
The Firestore test uses it through firebase-admin, which already brings it in as an optional dependency. Dropping our own declaration lets firebase-admin pick a version it supports, and removes the last knip dependency ignore.
cristianrgreco
marked this pull request as ready for review
October 12, 2026 14:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small follow-ups to #1492, one commit each:
knipuses a caret range (^6.39.0) like the other dev dependencies, instead of an exact version. The lockfile still installs 6.39.0.@google-cloud/firestoreas a dev dependency, and the knip ignore for it is removed. With that,knip.jsonchas no dependency ignores left.Why remove the Firestore declaration
The Firestore test imports
firebase-admin/firestoreand never imports@google-cloud/firestoredirectly.firebase-adminloads that package at runtime and already brings it in as an optional dependency. So the module's own declaration was a second, exact-pinned copy of the same requirement, and knip reported it as unused.Without it:
optional, becausefirebase-admin's optional dependency is the only thing requiring them.firebase-adminchooses a Firestore version it supports. Before, two exact pins (firebase-admin14.5.0 and@google-cloud/firestore9.2.0) had to be kept in step by hand.npm cidoes by default.Verification
npx vitest run packages/modules/gcloud/src/firestore-emulator-container.test.tswith Docker, after the removal: 1 of 1 passed.npm cisucceeds with the new lockfile.npm lsshowsknip@6.39.0and@google-cloud/firestore@9.2.0underfirebase-admin.npm run knipwith configuration hints treated as errors: passes.npm run format,npm run lint:ci,npm run check-compiles: pass.main: the root manifest'skniprange, the gcloud workspace's manifest entry, and theoptionalflag on those 25 packages. No versions change.Why this isn't breaking
Dev dependencies and tooling config only.
@testcontainers/gcloud's published dependencies don't change, and no package source changes.