Repository navigation
Support hackney 4 unix sockets and retire MinioContainer - #280
Merged
Merged
Conversation
hackney 4 pooled connections always use TCP, so http+unix:// URLs get resolved as hostnames and fail with :nxdomain. Disable pooling for unix socket Docker hosts and the ping probe. Lock hackney 4.8.5 so CI covers it. Fixes #279
Member
Author
|
minio/minio has been removed from Docker Hub, so the default image can no longer be pulled. Deprecate the module and raise with a pointer to MinistackContainer instead of failing on image pull.
jarlah
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #279.
hackney 4 unix sockets
hackney 4 checks out pooled connections as
hackney_tcpregardless of URL transport (hackney.erlconnect_pool_new), sohttp+unix://Docker hosts get DNS-resolved and fail with:nxdomain.pool: falsefor the Hackney adapter when the Docker host is a unix socket, and for the_pingprobe inDockerUrlmix.lockto hackney 4.8.5 (plus tesla 1.22.0, ex_aws 2.7.0) so CI actually exercises hackney 4MinioContainer
minio/miniohas been removed from Docker Hub (repo returns 404) andquay.io/minio/minionow requires auth, so the default image can't be pulled.MinioContainer.new/0is now@deprecatedand raises anArgumentErrorpointing toTestcontainers.MinistackContainer. The test asserts the raise.Testing