Skip to content

Drops logfile.logtag from jooq and tests - #347

Open
Tiihott wants to merge 2 commits into
teragrep:mainfrom
Tiihott:drop_logtag
Open

Drops logfile.logtag from jooq and tests#347
Tiihott wants to merge 2 commits into
teragrep:mainfrom
Tiihott:drop_logtag

Conversation

@Tiihott

@Tiihott Tiihott commented Mar 26, 2026

Copy link
Copy Markdown
Contributor

Description

Drops logfile.logtag column from jooq and tests.

Includes:

  • Updated jooq autogenerated code and test database with schema from REST-01 PR that drops the logtag column.
  • Updated tests with the changes to jooq and test database.

Resolves #304

This PR must not be merged before the schema changes to dropping logfile.logtag from journaldb have been approved in REST-01.

Checklists

Testing

General

  • I have checked that my test files and functions have meaningful names.
  • I have checked that each test tests only a single behavior.
  • I have done happy tests.
  • I have tested only my own code.
  • I have tested at least all public methods.

Assertions

  • I have checked that my tests use assertions and not runtime overhead.
  • I have checked that my tests end in assertions.
  • I have checked that there is no comparison statements in assertions.
  • I have checked that assertions are in tests and not in helper functions.
  • I have checked that assertions for iterables are outside of for loops and both sides of the iteration blocks.
  • I have checked that assertions are not tested inside consumers.

Testing Data

  • I have tested algorithms and anything else with the possibility of unbound growth.
  • I have checked that all testing data is local and fully replaceable or reproducible or both.
  • I have checked that all test files are standalone.
  • I have checked that all test-specific fake objects and classes are in the test directory.
  • I have checked that my tests do not contain anything related to customers, infrastructure or users.
  • I have checked that my tests do not contain non-generic information.
  • I have checked that my tests do not do external requests and are not privately or publicly routable.

Statements

  • I have checked that my tests do not use throws for exceptions.
  • I have checked that my tests do not use try-catch statements.
  • I have checked that my tests do not use if-else statements.

Java

  • I have checked that my tests for Java uses JUnit library.
  • I have checked that my tests for Java uses JUnit utilities for parameters.

Other

  • I have only tested public behavior and not private implementation details.
  • I have checked that my tests are not (partially) commented out.
  • I have checked that hand-crafted variables in assertions are used accordingly.
  • I have tested Object Equality.
  • I have checked that I do not have any manual tests or I have a valid reason for them and I have explained it in the PR description.

Code Quality

  • I have checked that my code follows metrics set in Procedure: Class Metrics.
  • I have checked that my code follows metrics set in Procedure: Method Metrics.
  • I have checked that my code follows metrics set in Procedure: Object Quality.
  • I have checked that my code does not have any NULL values.
  • I have checked my code does not contain FIXME or TODO comments.

@Tiihott Tiihott self-assigned this Mar 26, 2026
@Tiihott

Tiihott commented May 29, 2026

Copy link
Copy Markdown
Contributor Author

Rebased to main

@Tiihott
Tiihott marked this pull request as ready for review May 29, 2026 11:19
@Tiihott
Tiihott requested a review from elliVM May 29, 2026 11:20

@elliVM elliVM left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass and builds LGTM

@Tiihott Tiihott added the review Issues or pull requests waiting for a review label May 29, 2026
@Tiihott
Tiihott requested a review from kortemik May 29, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review Issues or pull requests waiting for a review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop logfile.logtag column from jooq and tests

2 participants