Repository navigation
web: fix 90s shutdown hang on every deploy - #423
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every deploy restart produced ~90 s of 502s:
Run()logged "shutdown signal received" and then hung until systemd's defaultTimeoutStopSecSIGKILLed it. The page-cache LISTEN goroutine holds a pool connection and waits on the server's root context, which the web command never cancels, so the deferredpool.Close()blocked forever.srv.Close()after the drain window so long polls/SSE release)Test targets:
internal/cache/pagecache(newTestListen_ReleasesConnOnCancel)journalctl -u shithubd-webshows Stopping→Stopped in seconds, not 90 s; 502 count per deploy near zero