Repository navigation
auth: deflake constant-time login test - #422
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestLogin_ConstantTimecompared mean request latency of an existing-user vs missing-user login with a 5x bound. The existing-user path also does throttle/audit DB writes, so under parallel CI load against the shared Postgres it failed (existing=66ms, missing=11ms) on an unrelated PR (#421).The property that matters is that the missing-user branch still pays for an argon2 verify. The test now measures that cost directly and asserts the missing-user median is at least half of it, keeping only a loose 10x divergence bound on medians.
Test targets:
internal/web/handlers/authgreen