Repository navigation
Conversation
There was a problem hiding this comment.
I reviewed this PR and didn't find any bugs. It's a broad toolchain and framework upgrade (TanStack Start, Vite+ 1.x, Vitest 5, a new Cloudflare test plugin), and you note the Workers test suite hasn't run yet, so a human look would still be worthwhile.
What was reviewed:
- The regenerated react-start 1.169.2 patch:
fetchandcreateServerEntryboth lazy-import@ tanstack/react-start/serverand cache the promise, which keeps the original intent. - pnpm-workspace.yaml: override bumps, the removed braces patch and its GHSA ignore, the dropped vite-plus-core extension, and the packageExtensions entry renamed to
@ cloudflare/vitest-plugin. - The Vitest v4 compatibility settings in vite.config.ts, the
.inputValidator()to.validator()renames at 3 call sites, and the mechanical switch of test imports tovite-plus/test.
Extended reasoning...
The change upgrades runtime dependencies (TanStack Start/Router, hono), swaps the test toolchain to Vite+ 1.2.0 and Vitest 5 with a renamed Cloudflare Workers test plugin, replaces a local patch to the server entry, and removes the braces security patch and its regression tests. None of it touches auth, crypto or data-handling logic. The changes to app code are only the server-function validator renames. I deferred because of how big the change is (the lockfile alone has about 2,600 changed lines), because of the major-version toolchain jumps, and because the Workers test suite has not run anywhere yet, with an open upstream workerd/Vitest 5 bug that could affect it.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
I reviewed the rebased version of this PR and didn't find any bugs. It hand-patches TanStack Start's server entry and renames the validator API on three server functions, one of them session-gated, so a human look would still be worthwhile.
What was reviewed:
- The 1.169.2 patch:
fetchand the lazycreateServerEntrywrapper each cache one import promise and delegatefetch. A rejected import stays cached, the same as the 1.168.60 patch. .inputValidator->.validatorinsrc/function/dash.tsandsrc/routes/confirm/$token.tsx/src/routes/connect/$token.tsx. The zod schemas are unchanged. I couldn't confirm the rename against the 1.169.2 sources because dependencies aren't installed here.- The
pnpm-workspace.yamloverrides, catalog, allowBuilds and release-age excludes match the version bumps. The lockfile adds no non-registry sources.
Extended reasoning...
The change bumps TanStack Start/Router, Vite+, vitest, hono and several overrides, regenerates about 1,600 lockfile lines and replaces a local patch to @ tanstack/react-start's default server entry. The security-sensitive part is the three server functions whose input validation now relies on the renamed .validator() builder: one is session-gated (disconnecting a dashboard account) and two load data by token. The patched server entry affects every request's startup path. I couldn't confirm the API rename against the installed 1.169.2 sources, and worker tests weren't run locally, so I chose defer over approve.
|
Caution Review the following alerts detected in dependencies. According to your organization's Security Policy, you must resolve all "Block" alerts before proceeding. Learn more about Socket for GitHub.
|
|
The latest Tipbot preview deployment for c70a257
|
Summary
Rebased onto #102, which cleared the earlier
pnpm auditfailure. This PR moves the dependencies #102 upgraded to their newer patch releases, fixes a range mismatch in a pinned dependency, and clears GHSA-p458-7748-mcp3. That advisory was published after #102 and also failsmain's audit: Vitest servers misapplyserver.fs.deny. It needs vite-plus 1.3.0 and Vitest 5.0.5.main(#102)@vitest/*)^7.29.7, butmainforces 7.29.6..inputValidator()was renamed to.validator(); this updates 3 call sites.@tanstack__react-start@1.169.2.patch. Upstream'screateServerEntrynow adds request scoping and error handling, so the patch lazy-loads it too.fsModuleCacheby default. vitest-plugin 1.4.2 can't read that cache, so every Workers test file failed withreadAll … .vitest-cache: no such file or directory(fixed in vitest-plugin 1.4.3). The cache is disabled for the Workers project only, with a TODO to remove it once vitest-plugin is on 1.4.3. 1.4.3 is still under Aegis's 7-day limit.workerd@1.20261012.1(from vitest-plugin 1.4.2's Miniflare) is added toallowBuilds.vite-plus@1.1.0and@babel/core@7.29.6entries are removed. The new versions are older than the 1-day minimum release age.srvxis pinned to 1.0.5 in the lockfile only. No overrides or audit suppressions are added.Validation
pnpm audit: only the two existing image-size findings remain (ignored).pnpm check,pnpm check:types,pnpm build: pass. The frozen-lockfile install passes, andpnpm install --lockfile-onlyleaves the lockfile unchanged.fsModuleCache: trueit fails with CI's exact error; withfalseit passes. The resolved config showsfsModuleCacheoff forworkersand on forunit.