Repository navigation
fix(docs): float Ask AI at bottom center - #1129
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
LGTM. This is a small CSS deletion that hands the Ask AI layout back to Vocs's default.
What was reviewed:
- All three removed
[data-v-ask-ai-container]blocks insrc/styles/globals.ts. Nothing else in the repo referencesask-ai, so no other code depended on them. - The
--tempo-docs-shell-widthand--tempo-docs-outline-widthvariables are still used inDocsNavigation.styles.tsandsurfaces.styles.ts, so removing these rules doesn't leave them unused. - The intended behavior change (the input is now visible below 1376px, which fixes the menu opened by cmd/ctrl+I being anchored to a hidden trigger) matches the code.
- Not done: the visual checks (
pnpm check:stylesand how it looks in a browser) weren't run in this review.
Extended reasoning...
The change only deletes 39 lines of global CSS overrides for the Ask AI container in one file, src/styles/globals.ts. It touches no security-sensitive surface. A search found no other references to the Ask AI container selector. The CSS variables it used are still referenced elsewhere. The intent is clear, the change is self-contained, no CODEOWNERS file covers the path, and no reviewer has raised an objection.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the custom
[data-v-ask-ai-container]overrides insrc/styles/globals.ts, which pinned the floating Ask AI input into the right outline column at widths of 1376px and up and hid it below that.Below 1376px the input was
display: none, but cmd/ctrl+I still opened its menu. The menu was anchored to the hidden trigger, so it rendered at the top-left with no width.With the overrides gone, Vocs's default applies: the input floats at the bottom center at every width, and cmd/ctrl+I opens the menu above it.
Checks:
pnpm check:styles,pnpm check:types. Verified in a browser at 1600px and 1200px, with the input closed and opened through the shortcut.