Skip to content

fix(earn): inset the vault demo select chevrons - #1128

Merged
struong merged 2 commits into
mainfrom
fix/earn-select-chevron
Nov 12, 2026
Merged

struong merged 2 commits into
mainfrom
fix/earn-select-chevron

Conversation

@struong

@struong struong commented Nov 12, 2026

Copy link
Copy Markdown
Member

The network and vault selects on /docs/earn/vaults used the browser's native arrow, which sat flush against the right border while the text had a 12px inset.

  • Draw the TDS ChevronDown as the select background (appearance: none), 12px from the inline end to match the text inset, with 36px end padding so long labels stay clear of it. RTL and dark theme handled.
  • Move the chevron data URIs into src/styles/select-chevron.ts and reuse them in the MCP explorer recipe, which already used the same pattern.

Checked with pnpm check:styles, pnpm check:types, the earn vault demo tests, and before/after Playwright screenshots of the page.

@vercel

vercel Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
tempo-docs Ready Ready Preview Nov 12, 2026 2:27am UTC

Request Review

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is a small styling fix that reuses a chevron pattern the repo already has.

What was reviewed:

  • The two SVG data URLs moved into src/styles/select-chevron.ts match the strings removed from the MCP explorer recipe byte for byte.
  • tokens.spacing['9'] resolves to 36px in src/styles/contract.ts, which is 12 + 16 + 8 and matches the comment.
  • The new select rules are scoped with &:is(select), so the shared inputClass on text inputs is unaffected. The dark-theme and RTL overrides use the same selector forms as the MCP explorer, and they sit cleanly beside the existing &:focus-visible rule.
Extended reasoning...

The change touches three style-only files. It pulls the inline chevron data URLs out into a shared constant and adds the same custom chevron styling to the earn vault demo selects. No security-sensitive surface is involved (no auth, data handling or user input processing). No CODEOWNERS or ANTOWNERS file exists, and the timeline shows no outstanding reviewer objections. The refactor was confirmed byte-identical and the new rules only apply to select elements, so the change is low risk and mechanical.

@struong
struong merged commit c646933 into main Nov 12, 2026
16 checks passed
@struong
struong deleted the fix/earn-select-chevron branch November 12, 2026 02:27

This branch was successfully deployed

1 active deployment
Preview — 2ad3369a Deployed Nov 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant