Repository navigation
fix(earn): inset the vault demo select chevrons - #1128
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
LGTM. This is a small styling fix that reuses a chevron pattern the repo already has.
What was reviewed:
- The two SVG data URLs moved into
src/styles/select-chevron.tsmatch the strings removed from the MCP explorer recipe byte for byte. tokens.spacing['9']resolves to 36px insrc/styles/contract.ts, which is 12 + 16 + 8 and matches the comment.- The new select rules are scoped with
&:is(select), so the sharedinputClasson text inputs is unaffected. The dark-theme and RTL overrides use the same selector forms as the MCP explorer, and they sit cleanly beside the existing&:focus-visiblerule.
Extended reasoning...
The change touches three style-only files. It pulls the inline chevron data URLs out into a shared constant and adds the same custom chevron styling to the earn vault demo selects. No security-sensitive surface is involved (no auth, data handling or user input processing). No CODEOWNERS or ANTOWNERS file exists, and the timeline shows no outstanding reviewer objections. The refactor was confirmed byte-identical and the new rules only apply to select elements, so the change is low risk and mechanical.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The network and vault selects on
/docs/earn/vaultsused the browser's native arrow, which sat flush against the right border while the text had a 12px inset.appearance: none), 12px from the inline end to match the text inset, with 36px end padding so long labels stay clear of it. RTL and dark theme handled.src/styles/select-chevron.tsand reuse them in the MCP explorer recipe, which already used the same pattern.Checked with
pnpm check:styles,pnpm check:types, the earn vault demo tests, and before/after Playwright screenshots of the page.