Repository navigation
chore(deps): bump glob to 14.0.2 under archiver-utils - #59
horsefacts wants to merge 2 commits into
Conversation
👁️ Cyclops Security Review✅ Reviewed 637a2cb (latest) · Coverage: partial · no open findings · report
|
There was a problem hiding this comment.
I re-reviewed the new commit that moves the pin to glob 14.0.3 and didn't find any bugs. The override forces archiver-utils 5 four major versions past its declared glob ^10, so a human should still check that glob 14 works with it before merging.
What was reviewed:
- The lockfile matches the new
'archiver-utils>glob': 14.0.3override. archiver-utils@ 5.0.2 now resolves glob 14.0.3, and the only churn is glob's own subtree: minimatch 11, path-scurry 3, lru-cache 11 and brace-expansion 5 came in, and the jackspeak/cliui chain went out. - The new engine floors (node 20 || >=22) are met by the repo's Node 22 toolchain.
- Not checked: the package sources aren't in this checkout, so I couldn't confirm by reading that glob 14 still exposes
require('glob').sync, and I didn't confirm the release age of 14.0.3. I also didn't runpnpm install --frozen-lockfileorpnpm verify. The PR title and description still say 14.0.2.
Extended reasoning...
The change adds one scoped pnpm override in pnpm-workspace.yaml and regenerates pnpm-lock.yaml. It affects only glob's dependency subtree under testcontainers/archiver in localnet and touches no source code and no auth, crypto or data-handling surface. It isn't an approval because the override pushes a transitive dependency outside its consumer's declared semver range, and I couldn't confirm by reading that glob 14 is API-compatible with archiver-utils 5. There is also an earlier inline comment from another reviewer on pnpm-workspace.yaml whose content I can't see, so I can't tell whether the follow-up commit addressed it.
Bumps
globfrom 10.5.0 to 14.0.2 underarchiver-utils(pulled in bytestcontainers->archiver@7inlocalnet), which also moves itsminimatchfrom 9.0.9 to 11.0.4.archiver-utils@5.0.2is the latest release and still declaresglob ^10;archiver@8and the latesttestcontainersdon't change that, so a parent upgrade can't reach glob 14 yet. This adds one scoped override,'archiver-utils>glob': 14.0.2, next to the existingprool>tarone, with a note to remove it when upstream upgrades.archiver-utilsonly callsglob.sync(pattern, options), which glob 14 still exports.packageManager); only glob's subtree changed (glob, minimatch, path-scurry, lru-cache, brace-expansion, balanced-match, @isaacs/nonrecursive-glob-match added; jackspeak, @isaacs/cliui and friends dropped). Resolved versions are all more than 7 days old.Checked:
pnpm install --frozen-lockfile --ignore-scriptspasses; inlocalnet,archiver-utilsresolves glob 14.0.2,file.expandmatches files, andarchiver('tar').glob(...)produces an archive.