Repository navigation
build: upgrade Node.js to 22.23.5 - #57
Conversation
👁️ Cyclops Security Review✅ Reviewed c22f433 (latest) · Coverage: partial · no open findings · report |
There was a problem hiding this comment.
LGTM. This is a one-line patch bump of the Node.js pin.
What was reviewed:
.nvmrcnow reads22.23.5and still ends with a single trailing newline. CI picks it up throughnode-version-file: .nvmrcin.github/actions/setup/action.yml.engines.nodeinpackage.jsonis>=22.23.4 <23, which already allows 22.23.5. No Dockerfile or workflow pins Node anywhere else.docs/development/README.mdsays "22.23.4 or newer in the 22.x line". That is still accurate, so the docs don't need an edit.
Extended reasoning...
The only change is to .nvmrc, which moves the pinned Node.js version from 22.23.4 to 22.23.5 within the 22.x line. It touches no source code and no security-sensitive surface such as auth, crypto or permissions. The engines range in package.json and the CI setup action that reads .nvmrc both work with the new version. There is no CODEOWNERS file and the PR timeline has no outstanding reviewer objections. That, plus the change being a mechanical version bump, is why I approved.
Upgrades Node.js to the 22.x security release 22.23.5 (release: Node.js 22).
Pins bumped:
.nvmrc: 22.23.4 → 22.23.5 (read byactions/setup-nodevianode-version-filein.github/actions/setup/action.yml)Left alone: the
engines.noderange inpackage.json(>=22.23.4 <23), which already admits 22.23.5.Checks:
git diff --check.