Skip to content

Restore wrapped public payload converters - #1913

Merged
tconley1428 merged 2 commits into
mainfrom
revert/unwrap-payload-converters
Oct 1, 2026
Merged

tconley1428 merged 2 commits into
mainfrom
revert/unwrap-payload-converters

Conversation

@tconley1428

Copy link
Copy Markdown
Contributor

Direct calls to payload converters exposed by a data converter, workflow, or activity should apply the same transfer type conversion as SDK serialization. Revert #1875 and #1867 so these APIs consistently return the wrapped converter, including DataConverter.default.payload_converter and the System Nexus model conversion accessor.

This restores converter wrapping at construction, removes the separate internal converter accessors and unwrapping helper, and restores the tests from before those changes. Public API documentation and an unreleased changelog entry describe the resulting behavior.

Spec clarification: temporalio/features#909

Validation:

  • 59 converter, System Nexus, and activity helper tests passed.
  • 16 focused serialization context, dynamic activity (including process execution), and payload visitor tests passed.
  • poe lint passed.
  • git diff --check passed.

@tconley1428
tconley1428 requested a review from a team as a code owner October 1, 2026 16:17
Comment thread temporalio/workflow/_context.py Outdated
Comment thread temporalio/activity.py Outdated
@tconley1428
tconley1428 merged commit b773d5d into main Oct 1, 2026
46 of 49 checks passed
@tconley1428
tconley1428 deleted the revert/unwrap-payload-converters branch October 1, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants