Restore wrapped public payload converters - #1913
Merged
Merged
Conversation
VegetarianOrc
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct calls to payload converters exposed by a data converter, workflow, or activity should apply the same transfer type conversion as SDK serialization. Revert #1875 and #1867 so these APIs consistently return the wrapped converter, including
DataConverter.default.payload_converterand the System Nexus model conversion accessor.This restores converter wrapping at construction, removes the separate internal converter accessors and unwrapping helper, and restores the tests from before those changes. Public API documentation and an unreleased changelog entry describe the resulting behavior.
Spec clarification: temporalio/features#909
Validation:
poe lintpassed.git diff --checkpassed.