[SDK Sentinel] Avoid encoded payload test workflow timeout - #1909
Merged
Conversation
tconley1428
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
This PR contains untrusted AI-generated code. Do not approve or run CI until a maintainer has reviewed the diff. SDK Sentinel verified that GitHub Actions remained approval-gated with zero executable jobs when this PR was opened.
Summary
Avoid a flaky timeout in the encoded activity-failure decoding test observed in [macOS Python 3.10 CI](https://github.com/temporalio/sdk-python/actions/runs/36762053347/job/110046813746). The bounded snapshot has no preceding equivalent success; this is the [first captured main failure](https://github.com/temporalio/sdk-python/actions/runs/36762053347).
Root cause
The test limited its entire workflow run to five seconds even though it verifies failure payload decoding. During a resource-saturated suite run, worker progress exceeded that deadline and the server closed the workflow before the decoding assertions completed.
Fix
Remove the unrelated workflow run deadline. The activity retains its three-second schedule-to-close timeout, and pytest still bounds the test at 60 seconds.
Validation
The unchanged focused test passed once, so the CI failure did not reproduce locally. After the change, the focused test passed once plus ten stress iterations. The unchanged baseline and candidate repository validator both passed. The macOS ARM Python 3.10 CI job remains required.
Validation status:
ci-validation-requiredhighhighmediumstandard— 1 changed file; 610 Bnot-reproduced— The exact unchanged test passed once on Linux Python 3.14; macOS ARM Python 3.10 was unavailable.pass-after-only— No new test was needed; the existing focused test passed once normally and ten times under flake-finder after the one-line change.Poe lint, bridge lint, and editable build) — passedPoe lint, bridge lint, and editable build) — passedInvestigator-run checks
poe test -s tests/worker/test_workflow.py::test_activity_failure_with_encoded_payload_is_decoded_in_workflow (before candidate)— passed; 1 attempt(s). The unchanged test passed; the CI failure did not reproduce locally.poe test -s -k test_activity_failure_with_encoded_payload_is_decoded_in_workflow— passed; 1 attempt(s). The focused test passed after the candidate.poe test -s --flake-finder --flake-runs=10 tests/worker/test_workflow.py -k test_activity_failure_with_encoded_payload_is_decoded_in_workflow— passed; 10 attempt(s). All ten post-candidate stress iterations passed.poe test -s --flake-finder --flake-runs=10 tests/contrib/openai_agents/test_openai_replay.py -k 'agents and tools'— passed; 20 attempt(s). Twenty focused cases for the separate replay cluster passed without reproducing its deadlock..ci-flake-runtime/input/validate.sh (trusted unchanged baseline)— passed; 1 attempt(s). The trusted baseline validation succeeded..ci-flake-runtime/input/validate.sh— passed; 1 attempt(s). The candidate passed formatting, lint, type checks, Rust bridge clippy, and editable bridge build.Required target CI
Residual risks
Automation provenance
5bb461265e6c1af29c5f25dbb871a7e67448c61eIf this finding should not be fixed, apply the
sdk-sentinel:false-positivelabel and close the PR. Sentinel will suppress the finding until its affected source changes.SDK Sentinel recurrence history
2026-09-30 19:12 UTC2026-09-30 19:12 UTC