Remove TemporalIdGenerator.seed_span_id and seed_trace_id

CHANGELOG.md

@@ -37,6 +37,8 @@ to include examples, links to docs, or any other relevant information.
   remain available at runtime and retain their static type information.
   New code should depend on `temporalio-openai-agents` directly and import
   `temporalio.openai_agents`.
+- `temporalio.contrib.opentelemetry`: removed `TemporalIdGenerator.seed_span_id()` and
+  `seed_trace_id()`.
 
 ### Fixed
 

temporalio/contrib/opentelemetry/_id_generator.py

@@ -1,5 +1,4 @@
 import random
-from contextvars import ContextVar
 
 from opentelemetry.sdk.trace.id_generator import IdGenerator
 from opentelemetry.trace import (
@@ -40,51 +39,18 @@ class TemporalIdGenerator(IdGenerator):
     inside a workflow execution, ensuring deterministic span and trace IDs
     across workflow replays. Falls back to standard random generation outside
     of workflows.
-
-    Can be seeded with OpenTelemetry span IDs from client context to maintain
-    proper span parenting across the client-workflow boundary.
     """
 
     def __init__(self, id_generator: IdGenerator):
         """Initialize a TemporalIdGenerator."""
         self._id_generator = id_generator
-        self._traces: ContextVar[tuple[int, ...]] = ContextVar(
-            "temporalio_otel_trace_id_seeds", default=()
-        )
-        self._spans: ContextVar[tuple[int, ...]] = ContextVar(
-            "temporalio_otel_span_id_seeds", default=()
-        )
-
-    def seed_span_id(self, span_id: int) -> None:
-        """Seed the generator with a span ID to use as the first result.
-
-        This is typically used to maintain OpenTelemetry span parenting
-        when crossing the client-workflow boundary.
-
-        Args:
-            span_id: The span ID to use as the first generated span ID.
-        """
-        self._spans.set((*self._spans.get(), span_id))
-
-    def seed_trace_id(self, trace_id: int) -> None:
-        """Seed the generator with a trace ID to use as the first result.
-
-        Args:
-            trace_id: The trace ID to use as the first generated trace ID.
-        """
-        self._traces.set((*self._traces.get(), trace_id))
 
     def generate_span_id(self) -> int:
         """Generate a span ID using Temporal's deterministic random when in workflow.
 
         Returns:
             A 64-bit span ID.
         """
-        spans = self._spans.get()
-        if spans:
-            self._spans.set(spans[:-1])
-            return spans[-1]
-
         if workflow_random := _get_workflow_random():
             span_id = workflow_random.getrandbits(64)
             while span_id == INVALID_SPAN_ID:
@@ -98,11 +64,6 @@ def generate_trace_id(self) -> int:
         Returns:
             A 128-bit trace ID.
         """
-        traces = self._traces.get()
-        if traces:
-            self._traces.set(traces[:-1])
-            return traces[-1]
-
         if workflow_random := _get_workflow_random():
             trace_id = workflow_random.getrandbits(128)
             while trace_id == INVALID_TRACE_ID:

tests/contrib/opentelemetry/test_opentelemetry_plugin.py

@@ -1,7 +1,5 @@
 import logging
-import threading
 import uuid
-from concurrent.futures import ThreadPoolExecutor
 from datetime import timedelta
 from typing import Any
 
@@ -12,7 +10,6 @@
 from opentelemetry.sdk.trace.export.in_memory_span_exporter import (
     InMemorySpanExporter,
 )
-from opentelemetry.sdk.trace.id_generator import RandomIdGenerator
 from opentelemetry.trace import (
     get_tracer,
 )
@@ -21,7 +18,6 @@
 from temporalio import activity, nexus, workflow
 from temporalio.client import Client, WorkflowFailureError
 from temporalio.contrib.opentelemetry import OpenTelemetryPlugin, create_tracer_provider
-from temporalio.contrib.opentelemetry._id_generator import TemporalIdGenerator
 from temporalio.exceptions import ApplicationError
 from temporalio.testing import WorkflowEnvironment
 
@@ -33,43 +29,6 @@
 logger = logging.getLogger(__name__)
 
 
-@pytest.mark.parametrize(
-    ("seed_method", "generate_method"),
-    [
-        ("seed_span_id", "generate_span_id"),
-        ("seed_trace_id", "generate_trace_id"),
-    ],
-)
-def test_temporal_id_generator_seeds_are_context_local(
-    seed_method: str, generate_method: str
-) -> None:
-    generator = TemporalIdGenerator(RandomIdGenerator())
-    first_seeded = threading.Event()
-    second_seeded = threading.Event()
-    first_generated = threading.Event()
-    seed_values = (123, 456)
-
-    def generate_first() -> int:
-        getattr(generator, seed_method)(seed_values[0])
-        first_seeded.set()
-        assert second_seeded.wait(timeout=5)
-        generated = getattr(generator, generate_method)()
-        first_generated.set()
-        return generated
-
-    def generate_second() -> int:
-        assert first_seeded.wait(timeout=5)
-        getattr(generator, seed_method)(seed_values[1])
-        second_seeded.set()
-        assert first_generated.wait(timeout=5)
-        return getattr(generator, generate_method)()
-
-    with ThreadPoolExecutor(max_workers=2) as executor:
-        first = executor.submit(generate_first)
-        second = executor.submit(generate_second)
-        assert (first.result(), second.result()) == seed_values
-
-
 @activity.defn
 async def simple_no_context_activity() -> str:
     with get_tracer(__name__).start_as_current_span("Activity"):