Apply Google ADK deterministic providers inside workflow tasks - #1854
Open
DABH wants to merge 2 commits into
Open
Apply Google ADK deterministic providers inside workflow tasks#1854DABH wants to merge 2 commits into
DABH wants to merge 2 commits into
Conversation
ADK keeps its time, id, and random providers in contextvars.ContextVars. GoogleAdkPlugin set them in the worker's context, but workflow tasks run on the workflow task executor's threads, which start with an empty context, so ADK code inside a workflow read the defaults: wall-clock time and uuid.uuid4() for session, event, invocation, and function-call ids. Only debug mode, which runs activations inline, saw the deterministic values. Rebind each google.adk.platform ContextVar to one whose default is the Temporal provider so it is visible from every context, on Worker and Replayer alike. Also install the random provider ADK added in 2.8.0 and raise the google-adk floor to 2.8.0.
Use workflow.time() for the time provider, warn when installing replaces a provider set earlier in the calling context, and document that overrides must be made after the worker starts and that ADK id and random generation raise ReadOnlyContextError in read-only contexts. Tests assert provider identity.
Contributor
Author
|
Notes for review:
|
There was a problem hiding this comment.
🟡 Changes recommended
ADK’s public reset functions can restore nondeterministic standard-library providers inside workflows.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Ensures Google ADK uses Temporal’s deterministic time, UUID, and random providers across worker and replay threads.
Changes:
- Installs thread-visible, idempotent ADK provider defaults.
- Adds worker, sandbox, replay, fallback, and override tests.
- Requires Google ADK 2.8.0 and documents compatibility implications.
File summaries
| File | Description |
|---|---|
temporalio/contrib/google_adk_agents/_plugin.py |
Implements deterministic provider installation. |
tests/contrib/google_adk_agents/test_adk_platform_providers.py |
Tests provider behavior across execution contexts. |
temporalio/contrib/google_adk_agents/README.md |
Documents provider semantics. |
pyproject.toml |
Raises the Google ADK minimum version. |
uv.lock |
Locks Google ADK 2.8.0 and dependencies. |
CHANGELOG.md |
Records the fix and replay compatibility warning. |
Review details
- Files reviewed: 5/6 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| UserWarning, | ||
| stacklevel=_stacklevel_outside_temporalio(), | ||
| ) | ||
| setattr(module, var_name, contextvars.ContextVar(current.name, default=provider)) |
patbeqo
requested changes
Sep 11, 2026
|
|
||
| def _deterministic_random_provider() -> random.Random: | ||
| if workflow.in_workflow(): | ||
| return workflow.random() |
There was a problem hiding this comment.
workflow.new_random() should be used instead to create a private stream for ADK, simlarly to the Otel integration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADK keeps its time and uuid providers in
contextvars.ContextVars, andGoogleAdkPluginset them from the worker's context. Workflow tasks run on the workflow task executor's threads, which start with an empty context, so inside a workflow ADK still used wall-clock time anduuid.uuid4()for session, event, invocation, and function-call ids. Only debug mode, which runs activations inline, saw the deterministic values.The plugin now rebinds each
google.adk.platformContextVar (time, uuid, and the random seam added in ADK 2.8.0) to one whose default is the Temporal provider, so it applies in every context onWorkerandReplayer, sandboxed or not. Installation is idempotent; outside a workflow the providers fall back to the standard library.Breaking: the
google-adkextra now requiresgoogle-adk>=2.8.0, the first release with the_randomseam.Tested with a real
Worker(sandboxed and unsandboxed) plus replay, and a fresh-thread check that fails on main. Lock and doc notes are in the first comment.Same approach as
_install_providerin #1675, which can rebase onto this.