Add temporalActivityAttempt attribute to RunActivity spans - #1851
Open
DABH wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RunActivityspans are created once per Activity attempt, but nothing on the span said which attempt it was, so tracing backends showed identical-looking sibling spans whenever an Activity retried. This adds atemporalActivityAttemptattribute (theActivityInfo.attemptnumber) next totemporalActivityIDonRunActivityspans, in bothOpenTelemetryPluginand the olderTracingInterceptor.Tests: a new plugin test runs an Activity that fails on its first attempt and asserts two
RunActivityspans carrying attempts 1 and 2, the first with error status. The existing comprehensive interceptor test now also asserts the attempt numbers on its retried activity. Changelog entry added under Unreleased / Added.Motivated by the Arize Phoenix tracing sample (AI-411), which otherwise has to derive the attempt number in a custom span processor.