Gracefully handle load driver iteration failures - #461
Draft
THardy98 wants to merge 4 commits into
Draft
Conversation
THardy98
force-pushed
the
fix/graceful-driver-failure
branch
from
September 3, 2026 16:59
86955e9 to
7a4c0d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Omes currently stops a load run when one iteration fails. In Kubernetes this can make a transient workflow error terminate and immediately restart the load-driver container, instead of maintaining load for the configured duration.
This change makes CLI-driven runs continue after terminal iteration failures by default. It records each completed logical iteration, logs a final success/failure and throughput summary, and treats a run that completed with tolerated failures as a degraded but successful CLI run. Library callers still receive a typed
IterationFailuresError, preserving their ability to apply a stricter policy.Operators that require the existing assertion-style behavior can use
--iteration-failure-policy=fail-fast. Retry behavior is unchanged and remains controlled independently by--max-iteration-attempts.Observability
The load-driver Prometheus endpoint now exposes
omes_iterations_total, labeled by scenario, outcome, and normalized status code. Full wrapped errors remain in structured per-iteration logs without introducing unbounded metric labels.Validation
golangci-lint --new-from-rev=HEADreports no new issues.TestKitchenSinkexternal dev-server clone and times out locally; the remaining affected packages pass.Fixes #453