Clarify Temporal Proxy fail-closed encryption - #5293
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📖 Docs PR preview links
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 88879edd8e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| Fail-closed does not mean that every request field is encrypted. Search Attributes remain unencrypted so the Temporal | ||
| Service can index them. Failure messages and call stacks are not codec-capable Payloads by default. See |
There was a problem hiding this comment.
When this paragraph narrows encryption to codec-capable Payloads and explains that Search Attributes and default failure fields remain unencrypted, the Mermaid diagram earlier in docs/production-deployment/temporal-proxy/encrypt-payloads.mdx still labels the entire outbound request as ciphertext and the entire upstream response as ciphertext response. Readers scanning the diagram therefore still receive the blanket guarantee this change is intended to remove; update those arrow labels to distinguish encrypted Payloads from the rest of each request or response.
AGENTS.md reference: AGENTS.md:L234-L242
Useful? React with 👍 / 👎.
Codex flagged that the ciphertext/ciphertext-response arrow labels in the fail-closed diagram still imply the whole request and response are encrypted, contradicting the note that Search Attributes and default failure fields stay unencrypted.
2 participants
Summary
Why
The existing documentation says that the default key makes encryption fail-closed, but does not explain which traffic and fields that guarantee covers. This change makes the operational and data-coverage boundaries explicit.
Validation