fix(security): 2 improvements across 2 files#4453
Open
tomaioo wants to merge 2 commits intotemporalio:mainfrom
Open
fix(security): 2 improvements across 2 files#4453tomaioo wants to merge 2 commits intotemporalio:mainfrom
tomaioo wants to merge 2 commits intotemporalio:mainfrom
Conversation
- Security: Build script allows path traversal via AI_COOKBOOK_OUTPUT_DIR - Security: Unvalidated href prop may enable javascript: URL injection Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
- Security: Build script allows path traversal via AI_COOKBOOK_OUTPUT_DIR - Security: Unvalidated href prop may enable javascript: URL injection Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
|
@tomaioo is attempting to deploy a commit to the Temporal Team on Vercel. A member of the Team first needs to authorize it. |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(security): 2 improvements across 2 files
Problem
Severity:
Medium| File:bin/ensure-ai-cookbook.js:L7The output directory is derived from the
AI_COOKBOOK_OUTPUT_DIRenvironment variable and joined directly into a filesystem path. An attacker (or misconfigured CI job) could supply values like../../...to write outside the repository root when creating the placeholder file.Solution
Validate and constrain
AI_COOKBOOK_OUTPUT_DIRto an allowlisted subdirectory. Usepath.resolveand enforce that the resolved path starts withWORKSPACE_ROOT(or a specific intended base directory) before writing.Changes
bin/ensure-ai-cookbook.js(modified)src/components/elements/CallToAction.js(modified)┆Attachments: EDU-6224 fix(security): 2 improvements across 2 files