Repository navigation
Conversation
Adds functionality for starting a fake Temporal Cloud server for use in unit testing. Updates the base reconciler and derived reconciler for namespace controller to use newly refactored `kube-temporal/pkg/testutil` library and `kube-temporal/pkg/types.Resource` interfaces from kube-temporal@v0.5.0 Signed-off-by: Jay Pipes <jay.pipes@temporal.io>
jaypipes
force-pushed
the
fake-cloud-service
branch
from
October 26, 2026 08:21
a74b139 to
aa26079
Compare
zainawaisn
reviewed
Oct 26, 2026
Comment on lines
+115
to
+118
| req := tcloudservicev1.GetNamespaceRequest{} | ||
| resp, err := tcc.GetNamespace(ctx, &req) | ||
| if err != nil { | ||
| return fmt.Errorf("failed getting tcloud namespace: %w", err) |
Collaborator
There was a problem hiding this comment.
I believe this would fail against the real Temporal server since an empty GetNamespaceRequest struct will cause GetNamespace() on the saas-control-plane side to emit an error. If this is just an item for later implementation, no worries then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds functionality for starting a fake Temporal Cloud server for use in unit testing. Updates the base reconciler and derived reconciler for namespace controller to use newly refactored
kube-temporal/pkg/testutillibrary andkube-temporal/pkg/types.Resourceinterfaces.Issue #7