Repository navigation
Temporal Cloud client/connection handling - #27
Merged
Merged
Conversation
jaypipes
force-pushed
the
cloud-connection
branch
from
October 18, 2026 15:56
ab24cd1 to
7a159bc
Compare
tomba7
approved these changes
Oct 19, 2026
tomba7
left a comment
tomba7
left a comment
Collaborator
There was a problem hiding this comment.
I like the overall shape and honestly think this is a great commit to start building and iterating on.
Builds on top of the temporalio/kube-temporal@v0.3.0 release and adds two new CRDs to the `cloud.temporal.io/v1alpha1` APIGroup: * `Connection` represents configuration for a client connection to a Temporal Cloud API endpoint (i.e. the Temporal CloudOps gRPC API) * `ClusterConnection` is the cluster-scoped counterpart to `Connection` Adds in a `pkg/temporal/cloud/connection` package that standardizes how to create a `github.com/temporalio/cloud-sdk-go/client.Client` object by reading an API Key from either a Kubernetes Secret or a file path defined in the `ConnectionSpec.Credentials.APIKey` struct. Issue #7 Signed-off-by: Jay Pipes <jay.pipes@temporal.io>
jaypipes
force-pushed
the
cloud-connection
branch
from
October 19, 2026 15:24
7a159bc to
af0e3d2
Compare
Collaborator
|
Thanks @jaypipes. Did a second pass and all looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of the temporalio/kube-temporal@v0.3.0 release and adds two new CRDs to the
cloud.temporal.io/v1alpha1APIGroup:Connectionrepresents configuration for a client connection to a Temporal Cloud API endpoint (i.e. the Temporal CloudOps gRPC API)ClusterConnectionis the cluster-scoped counterpart toConnectionAdds in a
pkg/temporal/cloud/connectionpackage that standardizes how to create agithub.com/temporalio/cloud-sdk-go/client.Clientobject by reading an API Key from either a Kubernetes Secret or a file path defined in theConnectionSpec.Credentials.APIKeystruct.Issue #7