Repository navigation
Preserve OpenAI Agents trace context across Temporal boundaries - #26
Merged
Merged
Conversation
Port the tracing fix and regression coverage from temporalio/sdk-python#1856 to the standalone OpenAI Agents integration. Co-authored-by: 1fanwang <1fannnw@gmail.com> Co-authored-by: David Hyde <DABH@users.noreply.github.com>
|
|
Port the validated test stabilization from temporalio/sdk-python#1870 to the standalone OpenAI Agents integration.
brianstrauch
force-pushed
the
fix/openai-agents-trace-context
branch
from
September 17, 2026 18:35
5e7f40a to
d46dc70
Compare
DABH
approved these changes
Sep 17, 2026
This was referenced Oct 1, 2026
tconley1428
pushed a commit
to temporalio/sdk-python
that referenced
this pull request
Oct 5, 2026
The OpenAI Agents OTel interceptor, the only caller of seed_span_id and seed_trace_id, now propagates the caller's span as a remote parent instead of re-minting it under the caller's IDs (temporalio/ai-integrations#26), and #1868 removes it from this repository. Drop the two methods, their context-local seed queues, the seed-consumption branches in the generate_* methods, and the test that only exercised the seeding.
tconley1428
pushed a commit
to temporalio/sdk-python
that referenced
this pull request
Oct 5, 2026
* Remove TemporalIdGenerator span/trace ID seeding The OpenAI Agents OTel interceptor, the only caller of seed_span_id and seed_trace_id, now propagates the caller's span as a remote parent instead of re-minting it under the caller's IDs (temporalio/ai-integrations#26), and #1868 removes it from this repository. Drop the two methods, their context-local seed queues, the seed-consumption branches in the generate_* methods, and the test that only exercised the seeding. * condense changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This ports the OpenAI Agents changes from temporalio/sdk-python#1856 and the validated test stabilization from temporalio/sdk-python#1870 into the standalone
temporalio-openai-agentspackage. The SDK-onlyTemporalIdGeneratorcleanup is intentionally excluded.Fixes temporalio/sdk-python#1852
Fixes temporalio/sdk-python#1853
Fixes temporalio/sdk-python#1855
Validation
make formatmake lintmake syncmake test PYTEST_ARGS="tests/test_openai_tracing.py::test_tracing -q"(10/10 stress attempts passed)make test PYTEST_ARGS="tests/test_openai_tracing.py"(24 passed)make test(246 passed before the test-only stabilization)make build