Repository navigation
Read the current skip-changelog label - #21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Changed the reusable changelog workflow to query the pull request API for its current labels instead of reading labels from the triggering event snapshot. Added the pull-requests read permission required for that query and documented the caller permission contract.
Why?
Pull request events can be queued and executed out of order. On temporalio/sdk-go#2624, two labeled-event runs passed, then a stale event with an empty labels snapshot ran later and superseded them with a failure even though skip-changelog was currently applied.
Reading current PR state makes every queued run agree with the label state at execution time.
Checklist
Closes: N/A
How was this tested:
The README now documents that callers must grant pull-requests read access.