Skip to content

feat(chains): expose storage.oci.encoding-format in CRD - #3871

Merged
tekton-robot merged 1 commit into
tektoncd:mainfrom
infernus01:feat/chains-oci-encoding-format
Aug 6, 2026
Merged

feat(chains): expose storage.oci.encoding-format in CRD#3871
tekton-robot merged 1 commit into
tektoncd:mainfrom
infernus01:feat/chains-oci-encoding-format

Conversation

@infernus01

Copy link
Copy Markdown
Member

Changes

tektoncd/chains#1691 added a new storage.oci.encoding-format config
key that controls how Chains serializes OCI signatures and attestations:
dsse (default, tag-based) or sigstore-bundle (OCI 1.1 Referrers API).

This PR exposes that key through the operator so it can be set via the
TektonChain and TektonConfig CRDs.

What was added

  • ChainProperties.StorageOCIEncodingFormat (tektonchain_types.go)
    — new string field with JSON tag "storage.oci.encoding-format,omitempty".
    The existing AddConfigMapValues transformer picks this up automatically
    via reflection — no changes to transform.go or transformers.go.

  • CRD validation (tektonchain_validation.go) — rejects values
    other than "", "dsse", and "sigstore-bundle" at admission time.

  • Validation tests (tektonchain_validation_test.go) — invalid
    value is rejected; both valid values are accepted.

  • Documentation (TektonChain.md, TektonConfig.md) — field
    added to the example YAML.

What was NOT changed

  • transform.go / transformers.go — not needed (reflection)
  • tektonchain_defaults.go — not needed (Chains defaults to dsse
    when the key is absent)
  • No new dependencies

Related

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

expose `storage.oci.encoding-format` config key in TektonChain and TektonConfig CRDs — allows configuring OCI 1.1 Referrers API storage via the operator

/kind feature

Signed-off-by: Shubham Bhardwaj <shubbhar@redhat.com>
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Aug 6, 2026
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 6, 2026
@codecov

codecov Bot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.57%. Comparing base (241265e) to head (0572c35).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3871   +/-   ##
=======================================
  Coverage   25.56%   25.57%           
=======================================
  Files         455      455           
  Lines       23924    23926    +2     
=======================================
+ Hits         6116     6118    +2     
  Misses      17113    17113           
  Partials      695      695           
Flag Coverage Δ
unit-tests 25.57% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jkhelil

jkhelil commented Aug 6, 2026

Copy link
Copy Markdown
Member

hi @infernus01 Thanks for the PR

@jkhelil

jkhelil commented Aug 6, 2026

Copy link
Copy Markdown
Member

/approve

@tekton-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkhelil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2026
@pratap0007

Copy link
Copy Markdown
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2026
@tekton-robot
tekton-robot merged commit 6b64911 into tektoncd:main Aug 6, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants