feat(chains): expose storage.oci.encoding-format in CRD - #3871
Merged
tekton-robot merged 1 commit intoAug 6, 2026
Conversation
Signed-off-by: Shubham Bhardwaj <shubbhar@redhat.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3871 +/- ##
=======================================
Coverage 25.56% 25.57%
=======================================
Files 455 455
Lines 23924 23926 +2
=======================================
+ Hits 6116 6118 +2
Misses 17113 17113
Partials 695 695
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
hi @infernus01 Thanks for the PR |
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jkhelil The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
tektoncd/chains#1691 added a new
storage.oci.encoding-formatconfigkey that controls how Chains serializes OCI signatures and attestations:
dsse(default, tag-based) orsigstore-bundle(OCI 1.1 Referrers API).This PR exposes that key through the operator so it can be set via the
TektonChain and TektonConfig CRDs.
What was added
ChainProperties.StorageOCIEncodingFormat(tektonchain_types.go)— new
stringfield with JSON tag"storage.oci.encoding-format,omitempty".The existing
AddConfigMapValuestransformer picks this up automaticallyvia reflection — no changes to
transform.goortransformers.go.CRD validation (
tektonchain_validation.go) — rejects valuesother than
"","dsse", and"sigstore-bundle"at admission time.Validation tests (
tektonchain_validation_test.go) — invalidvalue is rejected; both valid values are accepted.
Documentation (
TektonChain.md,TektonConfig.md) — fieldadded to the example YAML.
What was NOT changed
transform.go/transformers.go— not needed (reflection)tektonchain_defaults.go— not needed (Chains defaults todssewhen the key is absent)
Related
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes
/kind feature