Add agentic workflows context files#3387
Conversation
Fix two issues found during agentic workflow setup: - Makefile: add version check so local golangci-lint binary is reinstalled when it diverges from the version in ci.yaml (v2.7.2); add PKG variable to lint-go for fast single-package iteration - Remove unused resourceKind constants in tektonchain, tektonpipeline, and tektontrigger reconcilers that caused lint failures locally Signed-off-by: Jawed khelil <jkhelil@redhat.com> Assisted-by: Claude Sonnet 4.6 (via Cursor) Co-authored-by: Cursor <cursoragent@cursor.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/XXL
|
/kind/cleanup |
jkhelil
force-pushed
the
SRVKP-11820
branch
2 times, most recently
from
82e0bf0 to
c44001f
Compare
vdemeester
left a comment
vdemeester
left a comment
There was a problem hiding this comment.
Few questions, otherwise looks good. The 'AGENTS.md` is a bit bigger than 60 lines but I feel it is needed 👼🏼
| `knative.dev/pkg/apis` (`condSet.Manage(status).MarkTrue/MarkFalse`). Do not use | ||
| `controller-runtime` — it is not in this project. | ||
|
|
||
| **API layout** — all CRD types live in `pkg/apis/operator/v1alpha1/`. Each component |
There was a problem hiding this comment.
Do we want to specify the version here ? (aka pkg/apis/operator/ should be good enough, isn't it ?)
|
|
||
| --- | ||
|
|
||
| ## PR Conventions |
There was a problem hiding this comment.
We should have an entry stating that pull request have to follow the pull request template.
|
|
||
| For complete detection logic, see `references/footer-detection.md`. | ||
|
|
||
| ### Assisted-by |
There was a problem hiding this comment.
Naive question, Assisted-by or Co-authored ?
There was a problem hiding this comment.
“Co-authored” seems to better reflect what actually happen.
There was a problem hiding this comment.
This is subjective, but I lean towards Assisted-By. To me, authorship implies ownership and accountability. This is a broader discussion in the Open Source community though, e.g. in this VSCode issue, and was a recent point of discussion by the Linux kernel maintainers as well (who adopted "Assisted-by" in their contribution guidelines)
There was a problem hiding this comment.
Yeah I saw that as well, I may lean toward Assisted-by for most cases I guess, we can / should accept both though.. Maybe it depends on the involvement of the agent in the commit 😅
| @@ -0,0 +1,554 @@ | |||
| # Author Detection and Footer Generation | |||
|
|
|||
| Complete guide for detecting author information and generating required commit footers. | |||
There was a problem hiding this comment.
nit: these are called trailer(s) in the git realm (there is even git-interpret-trailers command to interact with it)
Adds tooling and documentation to support agentic workflows: - AGENTS.md: minimal context file following agent-readiness principles (single-command tests, fast single-package lint, conventions, architecture, InstallerSet details, skills) - .claude/skills/: commit-message and release-notes skills adapted from pipelines-as-code; PAC-specific references updated for the Tekton Operator project - .agents/skills/: same skills in Cursor agent format - .gitlint: commit message linting config with dependabot exclusion Signed-off-by: Jawed khelil <jkhelil@redhat.com> Assisted-by: Claude Sonnet 4.6 (via Cursor) Co-authored-by: Cursor <cursoragent@cursor.com>
aThorp96
left a comment
aThorp96
left a comment
There was a problem hiding this comment.
The suggestion for the (I assume, copy paste) error highlights an important point: AGENTS.md might be repository specific but commit types, trailers, release notes format, etc, are all pretty much standard across all of Tekton. If a 2k lines of skills has to be included in every repository it could result in maintenance issues as style guides change or skills need to be refined. Can the skill reference a shared skill in the plumbing more central repo? I think plumbing because it's vendored in every(?) repo, so an agent doesn't need to remotely fetch the skill reference/context.
| @@ -0,0 +1,269 @@ | |||
| # Commit Types Reference | |||
|
|
|||
| Complete reference for conventional commit types used in the Pipelines-as-Code project. | |||
There was a problem hiding this comment.
| Complete reference for conventional commit types used in the Pipelines-as-Code project. | |
| Complete reference for conventional commit types used in the Tekton Operator project. |
4 participants
Changes
Prepare the Tekton Operator repository for agentic workflows as part of SRVKP-11820.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes