test(cli): Drain subprocess output concurrently - #34
Merged
Merged
Conversation
Keep stderr separate without deadlocking on full pipes, disable telemetry in child processes, and use macOS 13-compatible synchronization. Exercise large stderr, output separation, and exit failures with local subprocess fixtures.
philprime
marked this pull request as ready for review
September 24, 2026 18:44
philprime
enabled auto-merge (squash)
September 24, 2026 18:45
Drain stderr on a dedicated thread so synchronous test callers cannot occupy every worker needed by the reader. Exercise 32 concurrent subprocesses to reproduce the macOS CI deadlock before the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract noninteractive subprocess capture from
feature/tui. Integration tests keep stdout and stderr separate, disable child-process telemetry, and use macOS 13-compatible synchronization.Concurrency
Stderr drains on a dedicated thread. Scheduling the reader on the global dispatch queue could deadlock when synchronous Swift Testing callers occupied every cooperative worker. A 32-case concurrent regression reproduced the macOS CI hang, and a process sample confirmed all workers were blocked waiting for queued readers.
Verification
The regression now passes on macOS and Linux.
make test,make analyze,make build, and live CLI integration tests passed locally. All actionable CI checks passed, including macOS and Linux tests and all four release build targets. This PR changes only test infrastructure.