Simpler call interface - #22
Open
vanderlee wants to merge 1 commit into
Open
Conversation
|
I Agree with @vanderlee Also something like $.toastmessage.Notice('some message here'); would be even better. |
|
I think this should be merged... @dbremer-tonn , is this dead? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current call interface (API) to toastmessage is somewhat uncommon and needlessly complicated. This is my simplified interface
Current:
$().toastmessage('showNoticeToast', 'some message here');
In my version:
$.toastmessage('notice', 'some message here');
Basically, it rids of the uncommon and wasteful '$()' notation and shortens the 'method' strings.
Additionally, you can now add a boolean to indicate stickyness. I use this particular switch for half the messages and this way I don't have to drop down to the object-using syntax.