test(e2e): drop --build from tags/snaps/merges that don't need build output - #10733
Open
davidfirst wants to merge 3 commits into
Open
davidfirst wants to merge 3 commits into
davidfirst wants to merge 3 commits into
Conversation
PR Summary by QodoSkip unnecessary builds across E2E tag, snap, and merge tests
AI Description
Diagram
High-Level Assessment
Files changed (72)
|
Code Review by Qodo
1.
|
![qodo-free-for-open-source-projects[bot]](https://avatars.githubusercontent.com/in/1068000?s=60&v=4){kind=small}
|
Code review by qodo was updated up to the latest commit 87b35c1 |
|
Code review by qodo was updated up to the latest commit 154424d |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--buildflag onbit tag,bit snapandbit lane mergeruns the full build pipeline. This is the slow part of these commands. Many e2e tests used the build variants of the helpers, but did not read any build output.This change replaces 195 of these calls in 63 files with the existing
...WithoutBuildhelpers.How the calls were selected:
--buildremoved.--buildif a test in itsdescribefailed without it, or if no test ran under it.package.json, published packages, deps-graph data, or build status keep the build.skip-publish-unpublished-dep,artifactsandpkg.All tests in the changed files pass locally.