Repository navigation
Update turret for rotation2d changes - #5
Merged
Samson560915 merged 12 commits intoNov 3, 2026
Merged
Conversation
… work on the angle in controlToTurretCentricPositionRaw rather than using the deprecated normalizeHeading function.
Contributor
Author
Above should be the documentation to show that this works. I can provide more documentation if required.
|
Contributor
|
@Samson560915 The code change looks good to me, can you confirm this works in sim? |
thetaback
reviewed
Oct 7, 2026
thetaback
left a comment
thetaback
left a comment
Contributor
There was a problem hiding this comment.
I looked over the TurretSubsystem a bit and realized there are some more code changes to make. Could you also test this in sim after you make these changes?
Contributor
There was a problem hiding this comment.
@Samson560915 can you make sure that this is correct and can be put back in? This may be why you were having trouble running it in sim as well.
Contributor
Author
There was a problem hiding this comment.
For this, do you want me to make it public, test in sim, and then make it private again?
Contributor
Author
Screen.Recording.2026-10-19.at.6.34.32.PM.mov |
…in 2d advantagescope.
Contributor
Author
|
Proof of robot spinning and targeting the hub. Screen.Recording.2026-10-28.at.7.31.18.AM.mov |
…ew of the simulation robot spinning accurately in coordinationlayer.
thetaback
requested changes
Oct 28, 2026
thetaback
left a comment
thetaback
left a comment
Contributor
There was a problem hiding this comment.
Only a few minor comments :)
…e-turret-for-rotation2d-changes
…r need it for testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actually update turret for rotation2d changes onto the correct branch.