Repository navigation
ci: use the PAT secret for release-please - #60
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #52 (work package 6). Follow-up to #57.
release-please now takes the repository secret
PAT(already used by other repositories of the organisation) instead ofRELEASE_PLEASE_TOKEN; without the secret it still falls back toGITHUB_TOKEN.docs/releasing.mdis updated to match.Why this matters now
The release PR #59 was opened while no such secret existed, so it ran only the GitGuardian check, none of the repository's checks. After this is merged, the next release-please run on
mainupdates #59 with the PAT, which should start the checks on it. If the checks do not start, the token lacks a permission (needs Contents, Pull requests and Issues, read and write, on this repository).Test plan
actionlinton the workflowtest,securityandsanitizechecks. This is the first real test of the token and can only be seen onmain.