Add a function to get tasks from multiple kinds in one pass - #749
Conversation
b1a20b9 to
5e8e72f
Compare
jcristau
left a comment
There was a problem hiding this comment.
Would you mind adding a test for the new function?
| def load_tasks_for_kinds(parameters, kinds, root_dir=None): | ||
| """ | ||
| Get all the tasks of a given kind. | ||
| Get all the tasks of a the given kinds. |
There was a problem hiding this comment.
| Get all the tasks of a the given kinds. | |
| Get all the tasks of the given kinds. |
Adding tests unveils that the fake_loader here sets |
|
There seem to be other places where we assume the name matches the label e.g. taskgraph/src/taskgraph/actions/retrigger.py Line 150 in 6317207 taskgraph/src/taskgraph/transforms/task.py Line 1331 in 6317207 |
This is especially useful when some of the kinds the caller is interested in is a dependency of another kind.
5e8e72f to
7ce050c
Compare
|
Can you merge this? |
This is especially useful when some of the kinds the caller is interested in is a dependency of another kind.