Repository navigation
fix(security): upgrade Pillow and restore validated dependency installs - #4
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Python and decoder requirements pyproject.toml, requirements.txt, README.md, scripts/test_build_data.py |
The Ruff target and documented minimum Python version change to 3.11. Pillow is pinned to 13.0.0. New tests check the Pillow pin and PNG/WebP decoding, including invalid image data. |
Offline bundle build test scripts/test_build_data.py |
A new test builds and validates a bundle from mocked sources. It checks manifest and icon fields, ZIP timestamps, and whether repeated builds produce identical archive bytes. |
Pull request validation and build workflow .github/workflows/build-release.yml, README.md |
Pull requests trigger validation when specified files change. A read-only validation job runs lint, format, compile, and unit tests. The build job excludes pull requests and adds unit tests. The README describes the workflow and test coverage. |
Priority:
Estimated code review effort: 3 (Moderate) | ~20 minutes
Change: Bug fix
Possibly related PRs
- tarkovtracker-org/RatScannerData#2: Both PRs change
.github/workflows/build-release.yml; this PR changes how scheduled events run and share thereleaseconcurrency group.
Merge Risk: 
Minimal · up to 1e7f1
-
No actionable merge-blocking risk remains; the PR is suitable to merge after normal checks.
Pre-merge checks: 
5
-
Full details: Title check
-
Explanation
The title names the two main parts of the changeset: the Pillow upgrade (12.3.0 to 13.0.0, with regenerated hashes) and the restored validated dependency installs in the workflow. It is specific and conventional, and it matches the PR objectives. The title is 71 characters, which is a little long but acceptable.
Full details: Description check
-
Explanation
The description matches the changeset. It covers the Pillow 13.0.0 pin and regenerated hashes, the workflow YAML fix, the read-only offline PR validation job with separate concurrency groups, the Python 3.11 documentation change, and the validation steps that were run.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 1 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Merged at 49e4fe6 after exact-head approval and passing checks. Post-merge verification passed on that SHA:
Validated artifact: https://github.com/tarkovtracker-org/RatScannerData/actions/runs/40797055492 Removed only this merged task’s local worktree and topic branches; the local master checkout is clean and up to date. |
Summary
--only-binary :all:command was invalid YAML; retain hash and binary-only enforcement in a block scalar.Validation
actionlintrejected the original workflow at line 50.ruff check scripts,ruff format --check scripts,actionlint .github/workflows/build-release.yml, LSP diagnostics, andgit diff --checkpassed.Risk / rollout
This is a major Pillow upgrade and drops Python 3.10 support; explicit maintainer merge approval is required. No generated production data, releases, billing settings, or security exceptions were changed. A full live upstream data rebuild was not run; hosted PR validation will exercise Python 3.13. The existing merge-to-master validation build does not publish a release.
Pillow release/security notes: https://pillow.readthedocs.io/en/stable/releasenotes/13.0.0.html