Repository navigation
fix(ui): preserve fixed dark palette on system theme changes - #88
Conversation
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Configure fixed dark provider src/App/Shared/MainLayout.razor, docs/agent-context/app-ui.md |
The provider disables system dark-mode observation. The UI guidance documents the fixed dark palette, including its brass accent. |
Verify palette across routes tests/RatScanner.UiTests/WebViewSmokeTests.cs, docs/agent-context/build-and-validation.md |
The WebView smoke test checks primary, primary-text, and surface colors while changing system schemes and navigating Tracking, About, and Settings. The validation checklist records the palette checks and screenshot capture. |
Estimated code review effort: 2 (Simple) | ~10 minutes
Possibly related issues
- Issue 87: The planning issue identifies the fixed-dark theme problem as a release follow-up, and this change implements that theme fix.
Merge Risk: 
90caf
-
No merge-blocking risk is identified for the fixed-dark palette change.
Pre-merge checks: 
-
Check name Status Explanation Resolution Docstring Coverage Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Write docstrings for the functions missing them to satisfy the coverage threshold. -
Check name Status Explanation Title check The title names the main change: the fix keeps the fixed dark palette when system theme changes occur. It matches the MainLayout.razor change that sets ObserveSystemDarkModeChange to false, which is t… Description check The description states the problem (system theme notifications switch the fixed-dark shell to the default light palette) and the fix (disabling system-theme observation on the shared provider). It als… Linked Issues check The PR meets the coding requirements in issue #86.src/App/Shared/MainLayout.razorsetsObserveSystemDarkModeChange="false"on the shared fixed-darkMudThemeProvider. `Fixed_dark_palette_survive…Out of Scope Changes check The changes stay within issue #86scope. The provider change fixes the fixed-dark palette behavior. The WebView regression test validates the affected navigation and palette. The agent-context updates…Full details: Title check
-
Explanation
The title names the main change: the fix keeps the fixed dark palette when system theme changes occur. It matches the MainLayout.razor change that sets ObserveSystemDarkModeChange to false, which is the core of the fix. The title uses the conventional fix(ui) prefix and is 60 characters long, which is within a normal length. It does not cover the regression test or the doc updates, which is acceptable.
Full details: Description check
-
Explanation
The description states the problem (system theme notifications switch the fixed-dark shell to the default light palette) and the fix (disabling system-theme observation on the shared provider). It also describes the added WebView2 regression test, the validation run, and the doc updates. These match the raw summary of changes in MainLayout.razor, WebViewSmokeTests.cs, and the agent-context docs.
Full details: Linked Issues check
-
Explanation
The PR meets the coding requirements in issue
#86.src/App/Shared/MainLayout.razorsetsObserveSystemDarkModeChange="false"on the shared fixed-darkMudThemeProvider.Fixed_dark_palette_survives_system_theme_changes_and_navigationemulates dark and light media changes, navigates Tracking, About, and General Settings, checks primary, text-primary, and surface colors, captures screenshots, and checks runtime failures. The PR description also records that removing the fix reproduced the default purple palette.
Full details: Out of Scope Changes check
-
Explanation
The changes stay within issue
#86scope. The provider change fixes the fixed-dark palette behavior. The WebView regression test validates the affected navigation and palette. The agent-context updates document the same provider behavior and validation. No unrelated display-scale implementation or unrelated product behavior is shown.
-
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files. (3 skipped: 3 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
System theme notifications could switch the fixed-dark shell to MudBlazor's default light palette, leaving dark text and purple controls on dark surfaces. Disable system-theme observation on the shared provider so the app and overlay keep their intended palette.
Adds a real WebView2 regression that changes dark/light media preferences, navigates Tracking/About/General Settings, checks computed accent/text/surface colors, and captures screenshots. Updates the UI and validation context.
Validation:
scripts/verify.ps1 -Mode Fullpassed: Debug/Release builds with zero warnings/errors, 440 unit tests passed in each configuration (6 optional local image-fixture tests skipped), and all 3 WebView tests passed.rgb(166, 154, 119)versus actual default purplergb(89, 74, 226).Fixes #86