Repository navigation
fix(scan): rebuild on stale engine scale; ignore minimized game window - #72
Merged
Merged
Conversation
- measure-idle.ps1 samples raw GPU engine RunningTime for the app and its WebView2 children (3D and all-engine percent per second). - IconScan_latency_profile reports engine build, cold, warm p50/max, rebuild, and first-scan-after-rebuild latency on the local fixtures, asserting identity every iteration. - Record the pre-fix baseline in performance-diagnostics.md. Claude-Session: https://claude.ai/code/session_01QFKiA2aswHyp8SnpraLxE2
The scan path rebuilt the engine only on the refresh that observed a viewport change, but RefreshGameDisplayConfiguration commits the new viewport first. A failed rebuild (or a concurrent scan that missed the one-shot flag) left the engine on the old scale until restart, and a display-DPI-only change rebuilt needlessly. - Rebuild when the published engine's scale differs from the scale for the committed viewport, so failures retry on the next scan. - Detect minimized Tarkov windows and keep the previous viewport on scan-path refreshes instead of flipping to the Graphics.ini/monitor fallback and back (each flip cost a synchronous rebuild on a click). Claude-Session: https://claude.ai/code/session_01QFKiA2aswHyp8SnpraLxE2
Summing RunningTime by engine type before the delta let one instance exiting cancel another's usage. Deltas now use instances present in both samples, then sum by type. Claude-Session: https://claude.ai/code/session_01QFKiA2aswHyp8SnpraLxE2
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Next included review available in 15 seconds. View limit details
|
The offline cache key depends on game mode and language; parallel config tests changed them mid-run and the harness skipped at random. Claude-Session: https://claude.ai/code/session_01QFKiA2aswHyp8SnpraLxE2
…x/display-review-72
Member
Author
|
Post-merge verification complete for master
Owned task branches/worktrees are being removed; theme comparison screenshots are retained locally as validation evidence. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Keep the previous game viewport during periodic scan-path refresh while EFT is minimized, avoiding fallback/rebuild churn. Explicit settings refresh still applies the detected configuration.
Compare the published RatEye processing scale against the current viewport on every scan, including when detection is throttled. Failed rebuilds are retried on later scans; display-DPI-only changes do not rebuild. Preserve merged warm-up foreground priority and engine lifetime protections.
Validation
Integrated master c938fa1 (#71/#74/#75/#77) at f5762af.
scripts/verify.ps1 -Mode Fullpassed.Limits and separate follow-up
No live EFT process was available for a real minimize/restore capture session; pure policy tests and actual call flow were checked. Screenshot review found an existing shared-theme contract problem, tracked in #86 with unchanged-source/blame evidence and a focused regression plan. The layout smoke does not test palette correctness. A further native check was stopped by physical Escape and no more app input was sent.
No dependency upgrades, release publication, or security-policy changes.