fix(osdtrace): prioritize MSG_OSD_REPOP in handle_full dispatch - #174
Merged
Conversation
Fix an issue where subop_w (MSG_OSD_REPOP) operations with zero write bytes (op.wb == 0) were misclassified as op_r instead of print_subop_w.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where replica write operations (
subop_w/MSG_OSD_REPOP) with zero write bytes (op.wb == 0) were misclassified as read operations (op_r) due toif (op.wb == 0)being evaluated before checkingop.type == MSG_OSD_REPOP.Changes Included
src/osdtrace.cc: Updatedhandle_full()event dispatch logic to checkop.type == MSG_OSD_REPOPfirst, ensuring all subop write operations are correctly formatted byprint_subop_wwith thesubop_woperation name.