Repository navigation
dataplane/packet_ident: support identifying stun - #433
Merged
Merged
Conversation
npry
requested review from
danderson,
dylan-tailscale and
nrc
as code owners
September 23, 2026 19:19
npry
added this pull request to stack #435
September 23, 2026 19:22
dylan-tailscale
approved these changes
Sep 23, 2026
dylan-tailscale
left a comment
dylan-tailscale
left a comment
Collaborator
There was a problem hiding this comment.
lgtm, one non-blocking suggestion
npry
force-pushed
the
npry/packet_ident.stun
branch
2 times, most recently
from
September 23, 2026 20:34
3a9a455 to
ef04bb1
Compare
These were separate to enforce strict dependence netstack -> netsock -> netcore (and allow incremental inclusion of deps). I no longer think it's worth the crate bloat to do this -- there isn't much of a cost. In the event anyone wants _just_ netcore, that's still accessible. The top-level crate is `#![no_std]` and doesn't pull in tokio or anything heavy unless you feature flag it in, so it seems fine to do this. Signed-off-by: Nathan Perry <nathan@tailscale.com> Change-Id: I9b559af57ee4d6f94c8ebad0d2f164c76a6a6964
npry
force-pushed
the
npry/packet_ident.stun
branch
from
September 24, 2026 07:31
ef04bb1 to
0d87cea
Compare
Wrappers to take `FnOnce` and convert it to `Fn` or `FnMut` by runtime- checking that the function is only ever called once and panicking otherwise. This is needed in a number of cases where we know but would have a hard time proving to rustc that the function is indeed called at most once. Signed-off-by: Nathan Perry <nathan@tailscale.com> Change-Id: I6093e8428891cf9cebb513338820f26b6a6a6964
Implement heuristics for identifying STUN packets, primarily based on the magic value. These weren't provided before, so incoming STUN traffic had been treated as WireGuard. Signed-off-by: Nathan Perry <nathan@tailscale.com> Change-Id: If0b13f3ae89ff3c30d74d68f595e072c6a6a6964
npry
force-pushed
the
npry/packet_ident.stun
branch
from
September 24, 2026 07:32
0d87cea to
ede063f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement heuristics for identifying STUN packets, primarily based on the magic value. These weren't provided before, so incoming STUN traffic had been treated as WireGuard.