fix(ssh): forward custom DERP map to ProxyCommand - #22
Open
zukka77 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix tailcat ssh with custom --derpmap-url
Summary
Fixes an issue where tailcat ssh could not connect using a short, RegionID-based token when --derpmap-url specified a custom DERP map.
tailcat ssh launches OpenSSH with a ProxyCommand that invokes tailcat again. That internal tailcat command forwarded --key, but not --derpmap-url, so it fell back to the default DERP map and could not resolve custom
RegionIDs.
Change
When a non-default DERP map URL is configured, the generated ProxyCommand now includes it:
tailcat --key=... --derpmap-url=https://derp.example.com/derpmap.json 22
Default-map behavior remains unchanged.
Test coverage
Added unit coverage verifying that: