tailcat: avoid repeated process-wide netns.SetEnabled side effect - #10
Closed
awdemos wants to merge 1 commit into
Closed
tailcat: avoid repeated process-wide netns.SetEnabled side effect#10awdemos wants to merge 1 commit into
awdemos wants to merge 1 commit into
Conversation
createEngine called netns.SetEnabled(false) every time it created a wgengine, which is once per Server/Client. That function toggles a process-wide setting, so repeatedly flipping it is an observable global side effect for programs that create multiple tailcat instances or mix tailcat with other networking code. Guard the call with a sync.Once so the process-wide disable happens at most once, and document why it is needed. Updates tailscale/tailcat (adversarial audit).
Member
|
What problem are you trying to solve here? This change doesn't look to solve any problem that I can see. The description seems a little confused. |
Member
|
You've burned my trust at this point sending a bunch of PRs that do nothing and have no tests (or have a test that already passed without your change) and don't have a corresponding issue or even a description of what the problem was. So I'm going to close this. If a human wants to tell me what the problem is, then we can fix it. We can even fix it with AI, but we need to know what we're fixing and verify it actually fixes it, first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createEngine called netns.SetEnabled(false) every time it created a wgengine, which is once per Server/Client. That function toggles a process-wide setting, so repeatedly flipping it is an observable global side effect for programs that create multiple tailcat instances or mix tailcat with other networking code.
Guard the call with a sync.Once so the process-wide disable happens at most once, and document why it is needed.