Repository navigation
mkctr: build the files layer in a deterministic order - #37
Closed
RaphaelFakhri wants to merge 1 commit into
Closed
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
layerFromFiles ranged over a map, so entries and their parent directory headers were written to the tar in a random order. Two builds from identical inputs produced layers with different digests, although the code sets zero modification times to make images reproducible. Visit the sources in sorted order. Fixes #35 Signed-off-by: Raphael Fakhri <153192858+RaphaelFakhri@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Write the files layer in a deterministic order so identical inputs produce the same layer digest.
layerFromFilesranged over a map, so tar entries and their parent directory headers were written in random order. Two builds from the same inputs produced layers with different digests, even though the code sets zero modification times to make images reproducible.This change visits the sources in sorted order.
The new test builds a layer 30 times from five files and checks that every
DiffIDis identical.This branch and the missing-source fix both add
mkctr_test.go. The second one merged needs a trivial rebase to combine the test files.Test command:
go test . -run Reproducible -vFixes #35