Repository navigation
mkctr: return an error instead of panicking on a missing --files source - #36
Closed
RaphaelFakhri wants to merge 1 commit into
Closed
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
The filepath.WalkDir callback in layerFromFiles ignored its err argument. When a source path passed to --files did not exist, WalkDir invoked the callback with a nil DirEntry and the callback dereferenced it, crashing with a nil pointer panic. Return the walk error, and also stop ignoring the error from writing directory headers. Fixes #34 Signed-off-by: Raphael Fakhri <153192858+RaphaelFakhri@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return an error instead of panicking when a
--filessource path does not exist.The
filepath.WalkDircallback inlayerFromFilesignored itserrargument. For a missing source,WalkDircalls the callback with a nilfs.DirEntry, andd.IsDir()then panicked with a nil pointer dereference.This change returns the walk error, which names the missing path, and stops discarding the error from writing the parent directory header.
The new tests cover the missing-source case and check that a directory of files is still copied into the layer.
Test command:
go test . -run LayerFromFiles -vFixes #34