Make update_tags consistent on databases and tables

Neither DatabaseItem nor TableItem tracks tags, and the Query Database
and Query Table responses do not include a tags element for tables, so
update_tags cannot work as it does for workbooks and datasources. Both
methods now share one explicit NotImplementedError that points to
add_tags and delete_tags, and tables.update_tags carries the same
@api(version="3.9") gate as the other tag methods.

Refs #735

Co-Authored-By: Claude Code <noreply@anthropic.com>

Author: jacalata

tableauserverclient/server/endpoint/databases_endpoint.py

@@ -20,6 +20,12 @@
     from tableauserverclient.server.request_options import RequestOptions
 
 
+_UPDATE_TAGS_MESSAGE = (
+    "update_tags is not supported for databases: the item does not track its tags. "
+    "Use add_tags and delete_tags with the item or its ID instead."
+)
+
+
 class Databases(Endpoint, TaggingMixin):
     def __init__(self, parent_srv):
         super().__init__(parent_srv)
@@ -247,5 +253,5 @@ def delete_tags(self, item: DatabaseItem | str, tags: Iterable[str]) -> None:
         super().delete_tags(item, tags)
 
     @api(version="3.9")
-    def update_tags(self, item: DatabaseItem) -> None:
-        raise NotImplementedError("Update tags is not supported for databases.")
+    def update_tags(self, item: DatabaseItem) -> None:  # type: ignore[override]
+        raise NotImplementedError(_UPDATE_TAGS_MESSAGE)

tableauserverclient/server/endpoint/tables_endpoint.py

@@ -19,6 +19,12 @@
     from tableauserverclient.models import DQWItem, PermissionsRule
 
 
+_UPDATE_TAGS_MESSAGE = (
+    "update_tags is not supported for tables: the item does not track its tags. "
+    "Use add_tags and delete_tags with the item or its ID instead."
+)
+
+
 class Tables(Endpoint, TaggingMixin[TableItem]):
     def __init__(self, parent_srv):
         super().__init__(parent_srv)
@@ -259,5 +265,6 @@ def add_tags(self, item: TableItem | str, tags: Iterable[str] | str) -> set[str]
     def delete_tags(self, item: TableItem | str, tags: Iterable[str] | str) -> None:
         return super().delete_tags(item, tags)
 
-    def update_tags(self, item: TableItem) -> None:  # type: ignore
-        raise NotImplementedError("Update tags is not implemented for TableItem")
+    @api(version="3.9")
+    def update_tags(self, item: TableItem) -> None:  # type: ignore[override]
+        raise NotImplementedError(_UPDATE_TAGS_MESSAGE)

test/test_database.py

@@ -183,3 +183,18 @@ def test_update_req_sends_content_permissions() -> None:
     item = TSC.DatabaseItem("test", content_permissions=TSC.DatabaseItem.ContentPermissions.ManagedByOwner)
     attrib = ET.fromstring(RequestFactory.Database.update_req(item)).findall("database")[0].attrib
     assert attrib == {"contentPermissions": "ManagedByOwner"}
+
+
+def test_update_tags_not_supported(server) -> None:
+    server.version = "3.9"
+    item = TSC.DatabaseItem("test")
+    item._id = "10224773-ecee-42ac-b822-d786b0b8e4d9"
+    with pytest.raises(NotImplementedError, match="add_tags and delete_tags"):
+        server.databases.update_tags(item)
+
+
+def test_update_tags_checks_version(server) -> None:
+    server.version = "3.5"
+    item = TSC.DatabaseItem("test")
+    with pytest.raises(TSC.server.exceptions.EndpointUnavailableError):
+        server.databases.update_tags(item)

test/test_table.py

@@ -90,3 +90,18 @@ def test_update_req_empty_strings_clear_fields() -> None:
     item.description = ""
     attrib = ET.fromstring(RequestFactory.Table.update_req(item)).findall("table")[0].attrib
     assert attrib == {"certificationNote": "", "description": ""}
+
+
+def test_update_tags_not_supported(server) -> None:
+    server.version = "3.9"
+    item = TSC.TableItem("test")
+    item._id = "10224773-ecee-42ac-b822-d786b0b8e4d9"
+    with pytest.raises(NotImplementedError, match="add_tags and delete_tags"):
+        server.tables.update_tags(item)
+
+
+def test_update_tags_checks_version(server) -> None:
+    server.version = "3.5"
+    item = TSC.TableItem("test")
+    with pytest.raises(TSC.server.exceptions.EndpointUnavailableError):
+        server.tables.update_tags(item)