Only send set fields in database and table update requests

The update requests always sent isCertified, so an item whose certified
value was never set sent isCertified="none". description and
certificationNote were only sent when non-empty, so they could not be
cleared. Send isCertified when certified is not None, and send
description and certificationNote whenever they are not None so an empty
string clears them.

The Update Database REST method accepts contentPermissions and the
docstring claims it can set permissions, but the value was never sent.
Send it when set.

Refs #735

Co-Authored-By: Claude Code <noreply@anthropic.com>

Author: jacalata

tableauserverclient/server/endpoint/databases_endpoint.py

@@ -119,7 +119,7 @@ def delete(self, database_id: str) -> None:
     @api(version="3.5")
     def update(self, database_item: DatabaseItem) -> DatabaseItem:
         """
-        Update the database description, certify the database, set permissions,
+        Update the database description, certify the database, set content permissions,
         or assign a User as the database contact.
 
         REST API: https://help.tableau.com/current/api/rest_api/en-us/REST/rest_api_ref_metadata.htm#update_database

tableauserverclient/server/request_factory.py

@@ -179,14 +179,18 @@ def update_req(self, database_item):
             contact_element = ET.SubElement(database_element, "contact")
             contact_element.attrib["id"] = database_item.contact_id
 
-        database_element.attrib["isCertified"] = str(database_item.certified).lower()
+        if database_item.certified is not None:
+            database_element.attrib["isCertified"] = str(database_item.certified).lower()
 
-        if database_item.certification_note:
+        if database_item.certification_note is not None:
             database_element.attrib["certificationNote"] = str(database_item.certification_note)
 
-        if database_item.description:
+        if database_item.description is not None:
             database_element.attrib["description"] = str(database_item.description)
 
+        if database_item.content_permissions is not None:
+            database_element.attrib["contentPermissions"] = str(database_item.content_permissions)
+
         return ET.tostring(xml_request)
 
 
@@ -945,12 +949,13 @@ def update_req(self, table_item):
             contact_element = ET.SubElement(table_element, "contact")
             contact_element.attrib["id"] = table_item.contact_id
 
-        table_element.attrib["isCertified"] = str(table_item.certified).lower()
+        if table_item.certified is not None:
+            table_element.attrib["isCertified"] = str(table_item.certified).lower()
 
-        if table_item.certification_note:
+        if table_item.certification_note is not None:
             table_element.attrib["certificationNote"] = str(table_item.certification_note)
 
-        if table_item.description:
+        if table_item.description is not None:
             table_element.attrib["description"] = str(table_item.description)
 
         return ET.tostring(xml_request)

test/test_database.py

@@ -1,10 +1,12 @@
 import warnings
 from pathlib import Path
+from xml.etree import ElementTree as ET
 
 import pytest
 import requests_mock
 
 import tableauserverclient as TSC
+from tableauserverclient.server.request_factory import RequestFactory
 
 TEST_ASSET_DIR = Path(__file__).parent / "assets"
 
@@ -150,3 +152,34 @@ def test_delete_table_default_permissions_swapped_arguments_warns(server):
             server.databases.delete_table_default_permissions(rule, database)
         assert m.call_count == 1
     assert record[0].filename == __file__
+
+
+def test_update_req_omits_unset_fields() -> None:
+    item = TSC.DatabaseItem("test")
+    xml = ET.fromstring(RequestFactory.Database.update_req(item))
+    assert xml.findall("database")[0].attrib == {}
+
+
+def test_update_req_sends_set_fields() -> None:
+    item = TSC.DatabaseItem("test")
+    item.certified = False
+    item.certification_note = "note"
+    item.description = "desc"
+    attrib = ET.fromstring(RequestFactory.Database.update_req(item)).findall("database")[0].attrib
+    assert attrib["isCertified"] == "false"
+    assert attrib["certificationNote"] == "note"
+    assert attrib["description"] == "desc"
+
+
+def test_update_req_empty_strings_clear_fields() -> None:
+    item = TSC.DatabaseItem("test")
+    item.certification_note = ""
+    item.description = ""
+    attrib = ET.fromstring(RequestFactory.Database.update_req(item)).findall("database")[0].attrib
+    assert attrib == {"certificationNote": "", "description": ""}
+
+
+def test_update_req_sends_content_permissions() -> None:
+    item = TSC.DatabaseItem("test", content_permissions=TSC.DatabaseItem.ContentPermissions.ManagedByOwner)
+    attrib = ET.fromstring(RequestFactory.Database.update_req(item)).findall("database")[0].attrib
+    assert attrib == {"contentPermissions": "ManagedByOwner"}

test/test_table.py

@@ -1,9 +1,11 @@
 from pathlib import Path
+from xml.etree import ElementTree as ET
 
 import pytest
 import requests_mock
 
 import tableauserverclient as TSC
+from tableauserverclient.server.request_factory import RequestFactory
 
 TEST_ASSET_DIR = Path(__file__).parent / "assets"
 
@@ -63,3 +65,28 @@ def test_delete(server: TSC.Server) -> None:
     with requests_mock.mock() as m:
         m.delete(server.tables.baseurl + "/0448d2ed-590d-4fa0-b272-a2a8a24555b5", status_code=204)
         server.tables.delete("0448d2ed-590d-4fa0-b272-a2a8a24555b5")
+
+
+def test_update_req_omits_unset_fields() -> None:
+    item = TSC.TableItem("test")
+    xml = ET.fromstring(RequestFactory.Table.update_req(item))
+    assert xml.findall("table")[0].attrib == {}
+
+
+def test_update_req_sends_set_fields() -> None:
+    item = TSC.TableItem("test")
+    item.certified = False
+    item.certification_note = "note"
+    item.description = "desc"
+    attrib = ET.fromstring(RequestFactory.Table.update_req(item)).findall("table")[0].attrib
+    assert attrib["isCertified"] == "false"
+    assert attrib["certificationNote"] == "note"
+    assert attrib["description"] == "desc"
+
+
+def test_update_req_empty_strings_clear_fields() -> None:
+    item = TSC.TableItem("test")
+    item.certification_note = ""
+    item.description = ""
+    attrib = ET.fromstring(RequestFactory.Table.update_req(item)).findall("table")[0].attrib
+    assert attrib == {"certificationNote": "", "description": ""}